Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore: πŸ”§ Redisson Auto Configuration 제거 및 도메인 λͺ¨λ“ˆ 의쑴 μ œμ–΄ #151

Merged
merged 10 commits into from
Aug 13, 2024

Conversation

psychology50
Copy link
Member

μž‘μ—… 이유

  • Batch λͺ¨λ“ˆμ€ Redisson이 ν•„μš” μ—†μŒμ—λ„ λΆˆκ΅¬ν•˜κ³  μžλ™ μ„€μ •λ˜λŠ” 문제 λ°œμƒ
  • ν•˜μœ„ λͺ¨λ“ˆμ—μ„œ Domain λͺ¨λ“ˆμ˜ Config에 λŒ€ν•œ μ„€μ • μ œμ–΄κΆŒ κ²°μ—¬

μž‘μ—… 사항

Importer λͺ¨λ“ˆμ— μžˆλŠ” ν΄λž˜μŠ€λŠ” #32 의 λ‚΄μš©κ³Ό 동일

spring:
  autoconfigure:
    exclude:
      - org.redisson.spring.starter.RedissonAutoConfigurationV2
  • 곡식 λ¬Έμ„œμ—μ„œ μ•Œλ €μ€€λŒ€λ‘œ Redisson ν™˜κ²½μ΄ μžλ™μœΌλ‘œ λ“±λ‘λ˜μ§€ μ•Šλ„λ‘ 제거

package kr.co.pennyway.api.config;

@Configuration
@EnablePennywayDomainConfig({
        PennywayDomainConfigGroup.REDISSON
})
public class DomainConfig {
}
  • RedissonConfig 및 κ΄€λ ¨ λͺ¨λ“  ν΄λž˜μŠ€μ—μ„œ μžλ™ 빈 등둝이 λ˜μ§€ μ•Šλ„λ‘ μ œκ±°ν•˜κΈ° μœ„ν•΄ μˆ˜μ •
    • @Component: RedissonConfigλ₯Ό μ‚¬μš©ν•œλ‹€λ©΄, @Bean이 λ“±λ‘λ˜λ„λ‘ μˆ˜λ™ 빈 μ„€μ •
    • @Configuration: @EnablePennywayDomainConfig μ–΄λ…Έν…Œμ΄μ…˜μœΌλ‘œ Redisson을 μ‚¬μš©ν•  ν•˜μœ„ λͺ¨λ“ˆμ—μ„œ λΆˆλŸ¬μ˜€λ„λ‘ μˆ˜μ •

image
image

  • Batchμ—μ„œλŠ” Redisson 연결이 λ˜μ§€ μ•Šκ³ , ApiλŠ” 정상 연결이 됨을 확인

image

  • ν˜Ήμ‹œλ‚˜ μ‹Άμ–΄ λΆ„μ‚° 락을 μ μš©ν•˜κ³  μžˆλŠ” API ν˜ΈμΆœν•΄λ΄€λŠ”λ° 정상 λ™μž‘ν•˜λŠ” 쀑

리뷰어가 μ€‘μ μ μœΌλ‘œ 확인해야 ν•˜λŠ” λΆ€λΆ„

  • Domain λͺ¨λ“ˆμ—μ„œ Redisson μžλ™ 등둝을 μ—†μ• λ²„λ ΈλŠ”λ°, 이게 μΆ”ν›„ λ¬Έμ œκ°€ λ˜μ§„ μ•Šμ„μ§€ μ•Œμ•„λ³΄λŠ” 쀑.
    • μ›λž˜λŠ” RedissonConfig에 @Import({RedissonAutoConfigurationV2})λ₯Ό λͺ…μ‹œν•΄μ€¬λŠ”λ°, Redisson 연결이 3λ²ˆμ΄λ‚˜ μ΄ˆκΈ°ν™”λ˜λŠ” λ°œμž‘μ„ μΌμœΌμΌœμ„œ κ·Έλƒ₯ μ—†μ• λ²„λ ΈμŒ

λ°œκ²¬ν•œ 이슈

  • μ—†μŒ

@psychology50 psychology50 added the refactoring λ¦¬νŒ©ν† λ§ μž‘μ—… label Aug 13, 2024
@psychology50 psychology50 self-assigned this Aug 13, 2024
@psychology50 psychology50 changed the title Api: πŸ”§ Redisson Auto Configuration 제거 및 도메인 λͺ¨λ“ˆ 의쑴 μ œμ–΄ Ignore: πŸ”§ Redisson Auto Configuration 제거 및 도메인 λͺ¨λ“ˆ 의쑴 μ œμ–΄ Aug 13, 2024
@psychology50 psychology50 merged commit a67b589 into dev Aug 13, 2024
2 checks passed
@psychology50 psychology50 deleted the fix/PW-493-separate-domain-dependency branch August 13, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring λ¦¬νŒ©ν† λ§ μž‘μ—…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant