Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Added UI Component for Member_List of a server #157

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

Hocng7
Copy link
Collaborator

@Hocng7 Hocng7 commented Mar 28, 2024

Summary of Changes:

Introduces the implementation of the Member_List component, which is responsible for displaying a list of members within a server in the chat application. The component serves to enhance community interaction and facilitate communication among members.

Key Changes:

Member_List Component:

  • The MemberList component is created to visualize the list of members within a server.
  • It renders member names along with avatars in a visually appealing manner.

Hardcoded Data:

  • Initially, hardcoded data for member names is provided to simulate the functionality.
    -This data can be later replaced with dynamic data fetched from the backend.

Page Structure (For ad-hoc testing purposes only):

  • A dedicated page, Member_List Page, is introduced to host the Member_List component.
  • The page encapsulates the Member_List component within a container for better organization.

Documentation:

  • Comments within the code provide usage instructions and describe the purpose and features of the Member_List Page component.
  • These comments aim to guide developers on the usage and functionality of the component.

Additional Considerations:

  • The implementation focuses solely on the frontend presentation of the member list.
  • Future iterations may involve dynamic data fetching from the backend to populate the member list.
  • Consideration for responsive design and accessibility ensures usability across various devices and user demographics.
  • This implementation lays the foundation for implementing the member list feature, providing a clear structure for further development and refinement.

Copy link
Owner

@ColinLefter ColinLefter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! A UI placeholder is needed to integrate the functionality for the server member list, which is what will follow.


export function MemberList() {
// Hardcoded member list
const memberList = [
Copy link
Owner

@ColinLefter ColinLefter Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with setting out the layout for the server member list! This is a critical component as we need to differentiate friends that belong to an account versus members that belong in a server, and the UI will be similar. Implementing the hardcoded member now as part of this pull request is a great approach because we need to follow the process of constructing front-end components first and then integrating the backend. This is because if anything changes in the UI later on, we would have to undo all the backend functionality, so it is better if this is finalized first.

@ColinLefter
Copy link
Owner

Also, excellent outline for this pull request. Listing out the Summary of Changes, Key Changes, Documentation and Additional Considerations is a great format and is something that we should all adopt when we write our pull requests.

@ColinLefter ColinLefter merged commit 5eed286 into main Mar 29, 2024
0 of 8 checks passed
@ColinLefter ColinLefter deleted the member_List-UI branch April 6, 2024 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants