Use libcurl websockets #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit feats/adds/introduces libcurl websockets as a replacement to curl-websockets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
to test it before making changes to Concord.
What?
This PR focus on replacing libcurl-websockets for libcurl websockets, build-in feature of libcurl to handle WS connections.
Why?
Although new, libcurl websockets have proven to be far more stable than libcurl-websockets, which causes and caused tons of bugs across numerous generations of Concord. This helps bot be stabler.
How?
By modifying websockets.c source to use libcurl websockets instead.
Testing?
Testing in personal bot, ran for at least 1 week without connection issues.