Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Warnings/Modlog] Stop changing reason removing custom info in Warnings cog #4820

Open
wants to merge 7 commits into
base: V3/develop
Choose a base branch
from
Open

[Warnings/Modlog] Stop changing reason removing custom info in Warnings cog #4820

wants to merge 7 commits into from

Conversation

Vexed01
Copy link
Contributor

@Vexed01 Vexed01 commented Feb 14, 2021 •
edited
Loading

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Add a way for custom permanent information to be added to modlog cases. This enhancement allows for the bugfix of warnings removing some information on the case (points and unwarn command). Closes #4775

@github-actions github-actions bot added Category: Core - Modlog This is related to the core Modlog API. Category: Cogs - Warnings This is related to the Warnings cog. labels Feb 14, 2021
@Jackenmen Jackenmen added Status: Needs Discussion Needs more discussion. Type: Enhancement Something meant to enhance existing Red features. Type: Feature New feature or request. labels Feb 15, 2021
@Jackenmen Jackenmen modified the milestones: Backlog, 3.4.7 Feb 15, 2021
@Vexed01 Vexed01 requested a review from Kowlin as a code owner June 29, 2021 15:20
@github-actions github-actions bot added Category: Cogs - Admin This is related to the Admin cog. Category: CI This is related to repository's CI configuration. Category: Meta This is related to the repository maintenance. labels Jun 29, 2021
@github-actions github-actions bot added Category: Cogs - Alias This is related to the Alias cog. Category: Core - API - Bank This is related to the core Bank API. Category: Bot Core Category: Cogs - Cleanup This is related to the Cleanup cog. labels Jun 29, 2021
@Jackenmen Jackenmen removed Category: Cogs - Admin This is related to the Admin cog. Category: Cogs - Alias This is related to the Alias cog. Category: Core - API - Bank This is related to the core Bank API. Category: Bot Core Category: CI This is related to repository's CI configuration. Category: Cogs - Cleanup This is related to the Cleanup cog. Category: Core - API - Config This is related to the `redbot.core.config` module and `redbot.core.drivers` package. Category: Cogs - Dev This is related to the Dev cog. Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Category: Cogs - Downloader This is related to the Downloader cog. Category: Cogs - Economy This is related to the Economy cog. Category: Cogs - Filter This is related to the Filter cog. Category: Cogs - General This is related to the General cog. Category: Core - Help This is related to our help command and/or HelpFormatter API. Category: Cogs - Image This is related to the Image cog. Category: Meta This is related to the repository maintenance. Category: Cogs - Mod This is related to the Mod cog. Category: Cogs - Modlog This is related to the Modlog cog. Category: Cogs - Mutes This is related to the Mutes cog. Category: Cogs - Permissions This is related to the Permissions cog. Category: Cogs - Reports This is related to the Reports cog. Category: Cogs - Streams This is related to the Streams cog. Category: Cogs - Trivia This is related to the Trivia cog. Category: Cogs - Trivia - Lists Changing or adding trivia lists. Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Category: Core - i18n This is related to the i18n core API or locale files. labels Jun 29, 2021
@Jackenmen
Copy link
Member

Quite cool - allows us to split the information provided by the bot and the information provided by the user.

I wonder if there are any other cases in core/core cogs where this could be used instead/in addition to reason.
For example, would it make sense to replace the usage of get_audit_reason() with a split between reason and extra_info?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: Cogs - Warnings This is related to the Warnings cog. Category: Core - Modlog This is related to the core Modlog API. Status: Needs Discussion Needs more discussion. Type: Enhancement Something meant to enhance existing Red features. Type: Feature New feature or request.
Projects
None yet
Milestone
Backlog of non-breaking changes
Development

Successfully merging this pull request may close these issues.

[Warnings] Unwarn command gets removed upon updating case
2 participants
@Vexed01 @Jackenmen