[Utils] [Chat Formatting] New rows to embeds util #4603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added rows_to_embeds util (in chat_formatting) added two unit tests
FixedThink
changed the title
FixedThink
changed the title
Drapersniper
suggested changes
Nov 13, 2020
- Renamed function from `rows_to_embeds` to `embeds_from_rows` - Changed "type, optional" to "Optional[type]". - Add embed field limit check (max = 25).
|
Updated the files based on the comments above. I renamed the function to |
Jackenmen
added
Category: Core - API - Utils Package
bobloy
reviewed
Nov 18, 2020
| @@ -284,7 +284,7 @@ def pagify( | |||
| yield in_text | |||
|
|
|||
|
|
|||
| def rows_to_embeds( | |||
| def embeds_from_rows( | |||
There was a problem hiding this comment.
Suggested change
| def embeds_from_rows( | |
| def embedify_list( |
Alternative name option. Follows the naming scheme of pagify
| @@ -203,7 +203,7 @@ def test_embed_list(): | |||
| base_embed = Embed(title="Test") | |||
| rows = list(str(i) for i in range(11)) | |||
|
|
|||
| embed_list = chat_formatting.rows_to_embeds( | |||
| embed_list = chat_formatting.embeds_from_rows( | |||
There was a problem hiding this comment.
Suggested change
| embed_list = chat_formatting.embeds_from_rows( | |
| embed_list = chat_formatting.embedify_list( |
| @@ -223,7 +223,7 @@ def test_embed_list_2(): | |||
| base_embed = Embed(title="Test") | |||
| rows = list(str(i) for i in range(11)) | |||
|
|
|||
| embed_list = chat_formatting.rows_to_embeds( | |||
| embed_list = chat_formatting.embeds_from_rows( | |||
There was a problem hiding this comment.
Suggested change
| embed_list = chat_formatting.embeds_from_rows( | |
| embed_list = chat_formatting.embedify_list( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
rows_to_embeds()util inchat_formatting.Resolves #4600.