[Trivia] Chemistry Quiz #4157
[Trivia] Chemistry Quiz #4157
Conversation
Chemistry quiz created by Hanumat, Stolas, and Hermes
|
I noticed there's an old chemistry trivia quiz PR (https://github.com/Cog-Creators/Red-DiscordBot/pull/4005/files). I'm thinking of combining the two trivia files into this PR's yaml. Let me know if that sounds good with you (whoever is reviewing this). In the mean time, any overlap that this quiz has with the other one has been removed from this yaml. |
|
First and foremost wanted to say thanks for PRing is great seeing new contributors.
That PR is only from the 22nd, so it's not stale. |
Drapersniper
added
the
Category: Cogs - Trivia - Lists
No problem, I figured you were probably thinking of leaving the two separate PRs intact, which is why I went ahead and re-committed a yaml that excludes any overlaping questions from the other PR. I'd argue that it would be cleaner to just combine the two yamls into one, seeing as how they're both general chemistry knowledge. I'll leave a comment on the other PR and see what the other author wants to do. Keep in mind, both PR#4005 and this include an addition of a file titled "chemistry.yaml" so there will be some merge conflict if left intact. |
|
You could make a PR to their branch and add your questions to their trivia and both of you coauthor it thats okay, and add yourself to the Author string in line of of their PR, so that it is co-authored. Alternatively it could be a variant on name like Personally I don't have a preference, whichever way you two find better here is fine with me. |
|
Sounds good! I'll start that conversation with the author of the other PR and update this one accordingly. |
|
Upon further discussion, we have been granted permission to combine the contents of #4005 into this PR's yaml file. This yaml has been linted accordingly and is ready to merge whenever. |
Jackenmen
added
Type: Feature
There was a problem hiding this comment.
The bulk of the content of this list is good, however the imgur image links provide some interesting challenges. All images used need to be licensed in a way that let us use them, and the links need to be from a red-controlled domain.
If you find public domain versions of these images (where they are not already), and message them (or their URLs) to @aikaterna (aikaterna#1393 on discord), she can provide you with appropriate URLs to replace the current imgur links with. If you'd rather not do that, or can't find public domain versions of any of the images, you can delete those questions instead.
Other than that, this looks good to go. Let me know when you've sorted that out.
Flame442
added
the
QA: Changes Requested
Type
Description of the changes
Added a chemistry quiz. Special thanks to authors Hanumat, Stolas, Hermes! Yaml linted with an online linter (removed url cause it sounded like I was advertising for that webpage)