-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make local blacklist and local whitelist mutually exclusive #4002
base: V3/develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested these changes yet (although it seems fine from the code), but there are two things that I noticed:
- the error messages should be worded differently - they should say something more along these lines (but not necessarily exactly like this - this is just a rough idea on what it should say):
The important part that needs to be communicated is that the other list is currently in use/non-empty; the information about how to clear it is less important and is more of a "tip".
Users can't be added to local whitelist while local blacklist is in use. You can use `{prefix}localblacklist clear` if you want to clear the local blacklist and use the local whitelist instead.
- this should probably also have same notice for bot-wide whitelist/blacklist - while it's a lot less important because bot owners are the only people that can change it (and they're not affected by it), it would still be good if they knew that their action might not work as intended
There are also some conflicts here, but you shouldn't worry about those until #3910 is merged (unless you want to deal with the conflict resolution twice :P) |
For your information, #3910 is now merged |
Type
Description of the changes
Prevent setting local blacklist/whitelist when the opposite is not empty. Fixes #4001.