Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run typos with a GitHub action on PRs #1770

Merged
merged 4 commits into from
Nov 17, 2024

Conversation

fturmel
Copy link
Collaborator

@fturmel fturmel commented Nov 16, 2024

False positives are infrequent enough that I think we could give this a shot. Let me know what you think.

https://github.com/crate-ci/typos

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for codingtrain ready!

Name Link
🔨 Latest commit a8f05b0
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/6738fa211e8ea90008eb8ef0
😎 Deploy Preview https://deploy-preview-1770--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fturmel fturmel marked this pull request as ready for review November 16, 2024 20:04
@shiffman
Copy link
Member

This is great, totally worth doing! The main thing that comes up with something like this is that the YT descriptions won't be fixed and I still have to manually do them. But that's mostly on me b/c @dipamsen did excellent work in #1621 and I really need to figure out a process for running it.

@shiffman shiffman merged commit e70b99f into CodingTrain:main Nov 17, 2024
6 checks passed
@fturmel
Copy link
Collaborator Author

fturmel commented Nov 17, 2024

The hope is that with typos running against PRs automatically, we'll be able to catch these mistakes before the YouTube description gets set in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants