Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Footer.js #1733

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Footer.js #1733

wants to merge 1 commit into from

Conversation

YadlaMani
Copy link

upated the twitter logo

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for codingtrain failed. Why did it fail? →

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/67028c666e4632538f985fdd

@YadlaMani
Copy link
Author

add the hacktoberfest label

@shiffman
Copy link
Member

shiffman commented Oct 6, 2024

Not sure why this failed, can you elaborate on the icon you've chosen and the changes you propose to make? Glad to consider it, thank you!

@YadlaMani
Copy link
Author

YadlaMani commented Oct 6, 2024

@shiffman just added new twitter logo from react-icons in footer

@fturmel
Copy link
Collaborator

fturmel commented Oct 6, 2024

If @shiffman wants the change, I'd prefer if the icon came from the Font Awesome 6 set like the others, so essentially FaXTwitter from react-icons/fa6.

The icon is also in the about page, not just the footer.

Would you only change the icons and not the labels and keep calling it "Twitter"?

EDIT: The build is failing because the proposed icon was only introduced in react-icons 5 (we're on 4). The substitution I'm recommending is available in v4.

@shiffman
Copy link
Member

shiffman commented Oct 6, 2024

To be honest, I think I prefer just leaving it as is. However, I do appreciate you @YadlaMani taking the time to engage with this repo! Is there something else you would like to work on? I suggest opening an issue to propose an idea and discuss before submitting a PR. All that said, I would consider @fturmel's suggestion and change the icon (but leave the text as "Twitter."

@YadlaMani
Copy link
Author

@shiffman is there any issue i could take upon I am willing to contribute to the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants