-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Challenge 73 - Acrostic #1671
Challenge 73 - Acrostic #1671
Conversation
✅ Deploy Preview for codingtrain ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Code example can be linked from https://github.com/CodingTrain/Coding-Challenges instead of the archived repo |
Thanks, much better (although still a broken example because of the Wordnik change, but there's not much we can do about this...). |
FYI the shiffman.net website is archived here! https://shiffman-archive.netlify.app/a2z/ I'm not maintaining it so I moved it off of shiffman.net (which now forwards to thecodingtrain.com) but I'm happy to link to any old but still useful material. I prefer to recreate the code examples from the videos as p5 web editor examples (if they don't require node.js). I have some working wordnik examples as part of my last fall class's materials: https://editor.p5js.org/a2zitp/collections/cgfJWhpsE Maybe I could update the code? |
Since v4 has been deprecated (at least until v5 is released), I think we will need to substitute a different API. (The code examples from the fall no longer return results.). ChatGPT suggested Datamuse as a substitute. Here is a sketch using it, although the code is slightly different -- the return options are more limited. The sketch creates the index.jpg file so if used the extra css will need to be edited. If this is OK I can edit it and create a code example. https://editor.p5js.org/kfahn/sketches/1-UXfIl9b |
Makes sense, I'll link there instead. I also opened a PR to fix the quick links in the archive shiffman/shiffman.net#136
These still work (are you OK leaking all these API keys though...?). It's only the word search API endpoint used in the "acrostic" challenge that seems to have been shut down (they say "deprecated" in their message, but it stopped returning data altogether). @kfahn22 That's awesome, thanks! Datamuse seems like a good substitute for this. I'll link to your sketch directly for now, but let me know if the link changes if we move it to the Coding Train user, etc. Feel free to make the changes to the PR directly too if that's easier. |
…n of `shiffman.net`
Responses to some notes above and I'm good to merge this when ready!
I removed the CSS styles, added a thank you to @kfahn22 in the comments, and saved it under the CT account: |
Going to merge this and then test #1621, thanks everyone for the efforts to getting this challenge added to the site! It's not a terribly popular one but I'll be doing it with my students this week so having the page of resources will be so helpful! |
Related #1627
https://deploy-preview-1671--codingtrain.netlify.app/challenges/73-acrostic
Created chapters for the video and migrated content from
https://github.com/CodingTrain/website-archive/blob/main/_CodingChallenges/073-acrostic.md?plain=1
Some notes:
I linked the source code from the archived website.It is however not working, the Wordnik words search API endpoint has been deprecated.TODO