Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase Submission for challenges/177-soft-body-character #1209

Closed
wants to merge 1 commit into from

Conversation

ch00ooch00oo
Copy link
Collaborator

Thank you Panna for your contribution! A member of the Coding Train team will review it shortly.

preview image

@ch00ooch00oo ch00ooch00oo added the showcase Passenger Showcase Submission label Sep 11, 2023
@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for codingtrain ready!

Name Link
🔨 Latest commit 17cd58b
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/64feed36218de700087f9684
😎 Deploy Preview https://deploy-preview-1209--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shiffman
Copy link
Member

Hi @panna3! These are wonderful! I might suggest combining #1209 and #1210 into one submission as they are very similar! Maybe you might like to add a button or mouse clock to change between the ring and the underlying lines? I can help with that if you like!! ✨

@panna3
Copy link
Contributor

panna3 commented Sep 12, 2023

Yes, I'll try adding buttons.

@panna3
Copy link
Contributor

panna3 commented Sep 12, 2023 via email

@panna3
Copy link
Contributor

panna3 commented Sep 12, 2023

Hi, I figured it out. I have fixed the code. Could you upload this one to the showcase instead of the other one? I see the other one is added.

@panna3
Copy link
Contributor

panna3 commented Sep 12, 2023

never mind. I changed the code of the other one that is already added to showcase.

@shiffman
Copy link
Member

Thanks @panna3 for updating, this is a wonderful project! I'll close this issue since, let me know if you have any more questions or if I can help in any other way!

@shiffman shiffman closed this Sep 17, 2023
@fturmel fturmel deleted the showcase-panna-1694428464 branch September 20, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
showcase Passenger Showcase Submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants