Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sound track #1168

Merged
merged 8 commits into from
Aug 28, 2023
Merged

Add Sound track #1168

merged 8 commits into from
Aug 28, 2023

Conversation

kfahn22
Copy link
Collaborator

@kfahn22 kfahn22 commented Jul 26, 2023

I haven't been able to find the code examples. If you can let me know where they are I can add (or I can recreate).

Notes:

  • I added an additional link to Jason Segal's therewasaguy/p5-music-viz repo - lots of useful stuff there but can delete.
  • I couldn't find the repo with sound file used in 5-adding sound effects. ( I added a link to https://opengameart.org as an alternative.)

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for codingtrain ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 22ed8c6
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/64c1638ee9947100082af030
😎 Deploy Preview https://deploy-preview-1168--codingtrain.netlify.app/tracks/sound/sound/11-sound-visualization-frequency-analysis
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipamsen
Copy link
Member

dipamsen commented Jul 26, 2023

@kfahn22 is this what you're looking for?
https://github.com/CodingTrain/website-archive/tree/main/Tutorials/P5JS/p5.js_sound
Edit: Looks like these examples are not on the web editor so they'll have to be ported.

@kfahn22
Copy link
Collaborator Author

kfahn22 commented Jul 26, 2023

The sound file for "Just Like a Rainbow" is 7MB so I don't think I can or should upload it to the code example sketches, correct? this.dot is 2.8MB, which is shorter but still pretty long. I am providing a link to the repo where songs can be found, but I am wondering whether I should add a smaller sound file to the example code sketches? For example, I am using this one in a sound visualization I created (it is 542KB). https://opengameart.org/content/sea-star

@dipamsen
Copy link
Member

I think we can also create a repo for the code examples which cannot be ported to the web editor.

@kfahn22
Copy link
Collaborator Author

kfahn22 commented Jul 26, 2023

This is ready for review.

The file size limit is 5MB so I have included this.dot in the sketches, but please let me know if this needs to change. @dipamsen it might be good to add "Just Like a Rainbow" and sound files from the sound effects sketch to a repo.

Also noting that the sketches for 1 (play sound), 6, (sound synthesis), and 7 (ADSR env) are working for me in Chrome but not in Safari. Maybe it is just me, but if not I can add a note to the sketches.

@kfahn22 kfahn22 changed the title Sound track-[WIP] Sound track Jul 26, 2023
@kfahn22 kfahn22 changed the title Sound track Add Sound track Jul 26, 2023
@shiffman
Copy link
Member

@kfahn22 I'm fine with using any sound file as long as the license allows it! I'll go ahead and merge and if you want to DM me I can dig up the original track or we can pick whatever you prefer!

@shiffman shiffman merged commit 59f8a7d into CodingTrain:main Aug 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants