-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sound track #1168
Add Sound track #1168
Conversation
✅ Deploy Preview for codingtrain ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@kfahn22 is this what you're looking for? |
The sound file for "Just Like a Rainbow" is 7MB so I don't think I can or should upload it to the code example sketches, correct? this.dot is 2.8MB, which is shorter but still pretty long. I am providing a link to the repo where songs can be found, but I am wondering whether I should add a smaller sound file to the example code sketches? For example, I am using this one in a sound visualization I created (it is 542KB). https://opengameart.org/content/sea-star |
I think we can also create a repo for the code examples which cannot be ported to the web editor. |
This is ready for review. The file size limit is 5MB so I have included this.dot in the sketches, but please let me know if this needs to change. @dipamsen it might be good to add "Just Like a Rainbow" and sound files from the sound effects sketch to a repo. Also noting that the sketches for 1 (play sound), 6, (sound synthesis), and 7 (ADSR env) are working for me in Chrome but not in Safari. Maybe it is just me, but if not I can add a note to the sketches. |
@kfahn22 I'm fine with using any sound file as long as the license allows it! I'll go ahead and merge and if you want to DM me I can dig up the original track or we can pick whatever you prefer! |
I haven't been able to find the code examples. If you can let me know where they are I can add (or I can recreate).
Notes: