Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a beautiful print method + real error throwing/checking #123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

a beautiful print method + real error throwing/checking #123

wants to merge 2 commits into from

Conversation

arjunpat
Copy link

@arjunpat arjunpat commented Jul 2, 2018

-refactored errors to JavaScript convention
-created a beautiful print method (try it in Google Chrome)
-cut down if statements and for statements where brackets weren't needed

-refactored errors to JavaScript convention
-created a beautiful print method (try it in Google Chrome)
-cut down if statements and for statements where brackets weren't needed
@arjunpat
Copy link
Author

arjunpat commented Jul 2, 2018

Just wanted to let you know that the error checking breaks the circleci test (but it will not people's code — it makes it MORE failsafe against bad inputs. It also removes the need for an empty return statement as throwing errors automatically breaks the program).

I am submitting code that breaks the test because it is usually more conventional to throw errors in javascript (especially errors that could cause the program to go haywire).

Also, it will break the print test because the new print method does not use console.table().

@arjunpat arjunpat changed the title minor edits + a beautiful print method a beautiful print method + real error throwing/checking Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant