Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1554

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

nate-fidalgo
Copy link

Add a YouTube video that describes how to do forks and pull request thru github website.
Its a great video that helps you figure out how to uses the github website better i am learning about it me included to 👍
Thanks for any acceptance of this PR

@Thommynator
Copy link

Thommynator commented Oct 3, 2020

@nate-fidalgo
Perhaps you should add some reviewers (e.g. contributers of this repo) to your pull request.
It could increase your chances to get it merged in. :)

@nate-fidalgo
Copy link
Author

@Thommynator
Not sure why adding contributors or reviewers to my repo would have more of a chance to get the pull request for a different repo merged in. :) Aka Rainbow-Topics. Do you mean giving contributor status to the Rainbow-Topics repo i forked over to my github account ? Because i could maybe see that if they didn't want to uses the merge /diff utilities on there github repo account. But they still have to fork over my copy temporarily .... basically not sure how you where thinking of it.

I do plan to some day give people who are interested in my projects contributor status and reviewer status.
But currently nobody is working on them but me and i am not at the point of adding contributors yet.
Anybody that wants to can fork over my projects as there all public as well as raise question issues to my project/repos.

Thanks for the comment. It helps because i just been figuring out the builtin bug/issue tracking works on git hub.
And where all the messages you raised and pull request comments go. It does take some getting use to on all this.

I have forked the Rainbow-Topics repo over to my repo temporarily to practice pull request , bug/issue tracking stuff for github.
I saw Rainbow-Topics repo was more like a repo for people learning github , i.e creating pull request , bug tracking , issue/ question raising ,...etc.

I tried to keep the pull request with value enough to have it merged in so no conflicts and a great videoblog/vblog that a computer science guy on youtube did for a similar project.

@nate-fidalgo
Copy link
Author

Even if the merge doesnt happen for this pull request its not a big deal. I would like it to happen to see what happens on my side interms of notifications and if github keeps track of how many pull request of mine go thru to what projects ...etc
There alot of neat analytics for the github account for your project yet you have to actually have pull request go thru on other projects to see if there is analytics builtin to github to keep track of who your helping ...etc. Not a big deal just something i like to see about. Most of the time if a project takes off the analytics for the repo/projects all you need to look at but its cool sometimes to look at analytics of what github accounts help other github accounts etc in analytics to. All this is not major to me as i focus more on coding/development/design. But this side does enhance collaboration that is understand how repo work in and out makes your project other then the merging part grow quick if it gets popular.

@Thommynator
Copy link

Hi 👋
I see that you want to practice the Git(hub) workflow and that's good, of course. :)
But are you aware, that your pull request is not in your forked repo, but in the original one from CodingTrain?
You can see the owner in front of the repo name (e.g. in the title or the URL).

@nate-fidalgo
Copy link
Author

No i actually wanted to incorporate the simple update to the readme file of CodingTrain,
When i was first learning what/how to do pull request.

I could also do pull request on my forked version but I meant the CodingTrain one.

Also i plan to add reviewers/contributors eventually to some of my repo's when the time is right.

Anyway thanks for the response next time all be better about double checking for response's to pull request or issues at the top of my github pages or emails notification.

@nate-fidalgo
Copy link
Author

Also just testing the closed with comments button vs comment button.

When do you close with comments button vs just comment button normally ?

I suppose when your threw with the pull request talk and dont want anybody else to comment back to you on this pull request?

@nate-fidalgo
Copy link
Author

anyway sorry about commenting on this unrelated question this should normally probably be done under either the issue page or discussion page. Rather then on a pull request page. But figured i ask to clear up these last issues.

@nate-fidalgo nate-fidalgo mentioned this pull request Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants