Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Sound Effects #88

Merged
merged 15 commits into from
Apr 13, 2024
Merged

Adding Sound Effects #88

merged 15 commits into from
Apr 13, 2024

Conversation

shiffman
Copy link
Member

Starting on #81. This is a proof of concepts, currently includes:

  • A "thinking" sound
  • A "typing" sound

Open to ideas for other sounds and sound effects! Possible additional features

  • Sound loops during a given state and then cuts off or fades out when next state begins
  • Button to enable / disable sound effects
  • Button for me to trigger specific sound effects like the "challenge bell"

@supercrafter100 @dipamsen I wonder if we want some kind of more proper "state" manager that knows what state bot is in and all things follow from that (message to animator, sound effects, etc.)

@supercrafter100
Copy link
Collaborator

supercrafter100 commented Apr 12, 2024

This is a classic "it works on my machine" issue but I seem to be experiencing issues with the files not being found. Would you be able to just rename them to single word files? That seems to work for me. NVM this didn't appear to work. It seems like it was an issue with the window installation of SOX. I was missing the mp3 libraries for it causing it to fail to play. Following the instructions outlined here seemed to fix it.

@supercrafter100
Copy link
Collaborator

supercrafter100 commented Apr 12, 2024

Additionally, do we need a way to disable these sounds? In case they get annoying during the performance? Especially because the boxing bell isn't even relevant during the initial conversations?

@shiffman
Copy link
Member Author

Yes, I should have a button for "sounds on" and "off" probably! I'll merge this and work it more in separate branches.

@shiffman shiffman merged commit f958cd1 into main Apr 13, 2024
@dipamsen dipamsen deleted the sound-effects branch April 16, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants