Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: aria-labels for static and dynamic links plus aria-labelledby, titles and descriptions for svg images #434

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Add aria-label to static links for accessibility
ttkapostol committed Jun 21, 2023
commit be85498eaaed4657b1b0e3e08ad51690dfdb44c9
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<!-- AUTO-GENERATED-CONTENT:START (STARTER) -->
<p align="center">
<a href="https://www.gatsbyjs.org">
<a alt="Link to page Gatsby JS" href="https://www.gatsbyjs.org">
<img alt="Gatsby" src="https://www.gatsbyjs.org/monogram.svg" width="60" />
</a>
</p>
6 changes: 3 additions & 3 deletions src/components/Sidebar/index.js
Original file line number Diff line number Diff line change
@@ -49,7 +49,7 @@ function FeaturedMentor({ mentor, isAuthor }) {
<SidebarTitle>
{ isAuthor ? 'Author' : 'Featured Mentor' }
</SidebarTitle>
<a href={`https://mentors.codingcoach.io/u/${mentor._id}`} className="block mb-4 w-full">
<a title href={`https://mentors.codingcoach.io/u/${mentor._id}`} className="block mb-4 w-full">
<img src={mentor.avatar} className="w-full" alt={mentor.name} />
</a>
<h3 className="font-body mb-1 text-lg truncate" title={mentor.name}>
@@ -109,7 +109,7 @@ function TwitchAd() {
return (
<div className="mb-12 pt-4 md:mr-4 md:flex-1 lg:flex-none">
<SidebarTitle>Follow us in Twitch</SidebarTitle>
<a href="https://www.twitch.tv/codingcoach/">
<a aria-label="Access our page on Twitch" href="https://www.twitch.tv/codingcoach/">
<img src={twitchImage} alt="Twitch Logo" />
</a>
</div>
@@ -120,7 +120,7 @@ function StoreAd() {
return (
<div className="mb-12 pt-4 md:mr-4 md:flex-1 lg:flex-none">
<SidebarTitle>Get the T-Shirt</SidebarTitle>
<a href="https://shop.spreadshirt.com/coding-coach" target="_blank" rel="noopener noreferrer">
<a aria-label="Buy coding-coach merchandise" href="https://shop.spreadshirt.com/coding-coach" target="_blank" rel="noopener noreferrer">
<img src={tshirtImage} alt="Coding Coach T-Shirt" />
</a>
</div>
4 changes: 2 additions & 2 deletions src/pages/404.js
Original file line number Diff line number Diff line change
@@ -23,13 +23,13 @@ const NotFoundPage = () => (
<Link to="/">home page</Link> would be a good idea. You might want to{' '}
<Link to="/blog">read the blog</Link>, we have very interesting
articles and tutorials! Maybe looking for{' '}
<a href="https://mentors.codingcoach.io">a mentor</a> to improve your
<a aria-label="Link to page with all the mentors" href="https://mentors.codingcoach.io">a mentor</a> to improve your
career?
</p>
<p>
How did you get here? Is this a broken link within the blog? Or maybe
a link from a third party website? Please{' '}
<a href="mailto:[email protected]">let us know</a> and we will fix it
<a aria-label="Send email to the page admin" href="mailto:[email protected]">let us know</a> and we will fix it
ASAP!
</p>
</div>