[FEAT] Improvements for POSIX & Upgrade VSCode to 1.83.0 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-olivier
force-pushed
the
feat-upgrade-vscode
branch
from
9fdd6ce
to
45b2670
Compare
CGNonofr
reviewed
Oct 16, 2023
|
@kaisalmen LGTM to me, it's published as |
Yes, I will test it with |
|
@kaisalmen the update is pretty minor, no big changes, less than 1 month update and no defect detected on our side, so we'll merge/release it to be able to update other libraries relying on it. If you notice any issue we'll do a patch! |
CGNonofr
approved these changes
Oct 16, 2023
There is monaco-languageclient PR #552 and the build now works. I had an older |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #207