Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always register file service override #158

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Always register file service override #158

merged 1 commit into from
Aug 4, 2023

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Aug 4, 2023

fix #156

fix: always register file service override
0b0f4e4 
otherwise some MainThread instantiation will fail
@CGNonofr CGNonofr requested a review from kaisalmen August 4, 2023 12:36
kaisalmen
kaisalmen approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Then there is no need to even configure it / allow to configure it with monaco-languageclient

@CGNonofr CGNonofr merged commit 339a825 into main Aug 4, 2023
1 check passed
@CGNonofr CGNonofr deleted the always-register-mandatory-file-service-override branch August 4, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisalmen kaisalmen kaisalmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initialization failing
2 participants
@CGNonofr @kaisalmen