Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional ExtHosts - improve codesplitting/treeshaking #137

Merged
merged 45 commits into from
Jul 27, 2023
Merged

Optional ExtHosts - improve codesplitting/treeshaking #137

merged 45 commits into from
Jul 27, 2023

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Jul 1, 2023 •
edited
Loading

based on #134

related to #136

It allows to only import some parts of a api.

It would allow for monaco-languageclient to only import what is required from the api by importing vscode/ext-hosts/languageClient only

(that's only 14 parts out of 26)

@CGNonofr CGNonofr requested a review from kaisalmen July 1, 2023 17:47
@CGNonofr CGNonofr changed the title Optional exhosts Optional ExtHosts Jul 1, 2023
@CGNonofr CGNonofr mentioned this pull request Jul 1, 2023
Closed
@CGNonofr CGNonofr changed the title Optional ExtHosts Optional ExtHosts - improve codesplitting/treeshaking Jul 4, 2023
@CGNonofr CGNonofr mentioned this pull request Jul 10, 2023
Merged
kaisalmen
kaisalmen previously approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I need to test the full stack with monaco-languageclient, so the approval of #146 is the one that counts.

@CGNonofr
Copy link
Contributor Author

LGTM. I need to test the full stack with monaco-languageclient, so the approval of #146 is the one that counts.

Yeah sure, we'll only merge the last one when everything will be reviewed

Loïc Mangeonjean added 20 commits July 25, 2023 20:12
feat: do not store logs on file memoryFileSystem
a995f90
feat: add outline view
1c6a3a9
feat: make workers work in extensions
ad3f610
clean: remove duplicated registration
70cc8c0
fix: only create model ref when absolutely necessary
8a98708
feat: build all extensions
0ebb7ef
fix: simplify loader, remove parameter
066927c
fix: transform configuration ext to match custom paths
df54b8d
feat: use id instead of random uuid to make debugging easier
3ef2fdd
feat: add new proposed apis
238cd09
feat: implement more apis
c9b1de8
fix: compile vscode extention media
debb9e8
fix: patch 2 vscode bugs
34d3350
feat: implement webviews
caf8434
feat: add sourceUrl comment for debug purpose
83a3a8b
fix: extract missing resources from extensions
c8a6c7a
fix: wrong module
e0e075e
feat: add an option to switch to newly created view
b577906
clean: remove logic not required anymore
4855be5 
Now, the vscode extension should be used
feat: improve file management
18f119f 
with ordered overlayfs, helpers...
Loïc Mangeonjean added 3 commits July 25, 2023 20:13
feat: update demo
5ae4285 
adapt to api changes
demonstrate new feature (markdown, readonly files, new language extensions...)
fix: remove check hash on rollup extensions
d8a0762
fix: typo
87a54b6
Loïc Mangeonjean added 22 commits July 25, 2023 20:26
refactor: rename vscode-service to vscode-apis
d4c2794
refactor: do not enumerate all files by hands
1a11167
feat: split extHosts, make them optional
d509e3d
clean: remove unused service
e76253b
fix: extHosts don't exist anymore in StandaloneServices injector
1c14e5f
fix: update demo
d10c10d
fix: keep more workbench contributions
df1897a
refactor: move code
c7a3b04
feat: add include/exclude parameter when importing vscode file
b7e7f58
fix: include only relevant code
0bc6309
feat: add list of required extHost for languageClient
4ee9a8f
fix: patch ast-types to handle PropertyDefinition
dd23b62 
https://github.com/benjamn/ast-types/pull/727/files
fix: help rollup treeshaking
50099ab
fix: prevent crash when views not used
909fadf
feat: weak import class
7fedb22
lib: update dependencies
a031757
refactor: build default extensions in another rollup config
017882d
fix: remove build warnings
684eea1
chore: update demo dependencies
90fe279
fix: prevent errors when view services are not used
ad6393f
fix: remove keybinding settings when editor part is not displayed
771a219
feat: add option to disable global picker
51fbe21
@CGNonofr CGNonofr merged commit 51fbe21 into main Jul 27, 2023
1 check passed
@CGNonofr CGNonofr deleted the optional-exhosts branch July 27, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisalmen kaisalmen kaisalmen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CGNonofr @kaisalmen