Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to also add build-dep for runtime-depends #2

Open
wants to merge 1 commit into
base: bst
Choose a base branch
from

Conversation

harrysarson
Copy link

@harrysarson harrysarson commented Feb 3, 2025

Superflore is correct to generate runtime dependencies when an
dependency is needed to provide headers and libraries needed to consume
an element but not to build it. Some tooling struggles to interpret the
c/c++ dependency graph when the dependencies are represented as
runtime-dependencies.

This commit adds a flag to additionally generate a build-dependency
for elements that depend on a ROS package that defines a package as
a runtime dependency.

@harrysarson harrysarson force-pushed the harry/build-dependancies-for-build-export branch from de1204c to 22e9728 Compare February 3, 2025 17:44
@tom--pollard
Copy link
Member

additional generate -> additionally generate in the commit message

@tom--pollard
Copy link
Member

It might just be me, but commit body doesn't match up to the commit title to me? The title references the addition of a build-dep, but the body describes the ability to control a runtime dep? Could just be me being confused though

@harrysarson
Copy link
Author

The title references the addition of a build-dep, but the body describes the ability to control a runtime dep?

For test build[tool]-export-dependencies we already generate a runtime-dep and with this commit also generate a build-dep. Let me try and update to make this clearer.

@harrysarson harrysarson changed the title Add flag for generating build dep for exported dep Add flag to also add build-dep for exports-depends Feb 7, 2025
@harrysarson harrysarson force-pushed the harry/build-dependancies-for-build-export branch from 22e9728 to a1deb7c Compare February 7, 2025 16:24
@harrysarson
Copy link
Author

Ah! Looking at the code the comment is out of date, we do this for all runtime dependencies. I should update the commit message and also the flag name

Superflore  is correct to generate runtime dependencies when an
dependency is needed to provide headers and libraries needed to consume
an element but not to build it. Some tooling struggles to interpret the
c/c++ dependency graph when the dependencies are represented as
runtime-dependencies.

This commit adds a flag to additionally generate a build-dependency
for elements that depend on a ROS package that defines a package as
a runtime dependency.
@harrysarson harrysarson force-pushed the harry/build-dependancies-for-build-export branch from a1deb7c to 415c0e5 Compare February 7, 2025 17:02
@harrysarson harrysarson changed the title Add flag to also add build-dep for exports-depends Add flag to also add build-dep for runtime-depends Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants