Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: outline error workarounds #33

Merged
merged 4 commits into from
Feb 26, 2024
Merged

feat: outline error workarounds #33

merged 4 commits into from
Feb 26, 2024

Conversation

hungluu
Copy link
Collaborator

@hungluu hungluu commented Feb 26, 2024 •
edited
Loading

Required information

What features / fixes included in this PR:

  • On outline's 429 error, indicate that import is being retried
  • On outline's 503 error, indicate that import is being retried (at max 3 times)
  • On any other cases with errors, indicate that document should be imported manually instead

PR Checklist:

  • Follow the style of the surrounding code
  • Manual tests
  • Write tests to cover all possible scenarios
  • PR has appropriate labels added (needs-testing, needs-review, etc.)
  • For bug-fixing PR, has a push to snapshot failed scenarios triggered by CI

Nice to have information

Related Flow Diagram

Diagram

Screenshots or Records

429 Error 503 Error with retry max 3 times Other error cases
image image image

Steps to test:

Other concerns:

@hungluu hungluu merged commit e4adc19 into main Feb 26, 2024
1 check passed
@hungluu hungluu deleted the feat/outline-error-workarounds branch February 26, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duhoang00 duhoang00 duhoang00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import errors should indicate workarounds for users
2 participants
@hungluu @duhoang00