Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove dead code #976

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Chore: Remove dead code #976

merged 6 commits into from
Oct 2, 2024

Conversation

danielmbrasil
Copy link
Contributor

What this PR do ?

This PR cleans up dead code from the codebase.

Related Issues

Closes #961
Closes #962
Closes #963
Closes #964
Closes #965
Closes #966

Screenshots (if applicable)

Additional Notes (if any)

@wrspada02
Copy link
Contributor

wrspada02 commented Oct 2, 2024

LGTM
Javascript tests:
Screenshot 2024-10-02 at 14 27 30

Ruby tests:
Screenshot 2024-10-02 at 14 29 10

Browser check: No errors, no console errors
Screenshot 2024-10-02 at 14 31 48

Copy link
Contributor

@wrspada02 wrspada02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@talyssonoc talyssonoc merged commit 336910c into master Oct 2, 2024
4 checks passed
@talyssonoc talyssonoc deleted the chore/remove-dead-code branch October 2, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants