Fix/pusher fake config #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guilherme-NL
force-pushed
the
fix/pusher-fake-config
branch
from
9a82a68
to
c7f7375
Compare
talyssonoc
reviewed
Oct 24, 2023
kabernardes
approved these changes
Oct 25, 2023
Guilherme-NL
force-pushed
the
fix/pusher-fake-config
branch
from
6a47399
to
daaed0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pusherfake service is currently not functional and the purpose of this PR is to configure the pusherfake service.
Dockerfile and docker-compose config references:
https://github.com/oliverlundquist/pusher-local-dev-server/blob/master/docker-compose.yml
https://github.com/gregeinfrank/docker-pusher-fake/blob/master/Dockerfile
The Beta::ProjectsController was receiving the slug instead of the project ID in the parameter list. This led to inconsistency in the frontend, which was unable to connect to the correct Pusher channel. As a result, v2 was not receiving the Pusher updates.