Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: product metabox for fields attach #382

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 18, 2024

Summary

Made the interface look like the one from PRO for PPOM in the product meta box.

Will affect visual aspect of the product

YES

Screenshots

image

Test instructions

  • Go to WooCommerce > All Products and choose a product.
  • On the product page, check the metabox tab PPOM Fields
  • You should see the Upsell, and all the functionality should work.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/ppom-pro/issues/395

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Sep 18, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 18, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review September 18, 2024 15:33
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Sep 18, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 18, 2024

Plugin build for 9be5ec9 is ready 🛎️!

inc/admin.php Outdated Show resolved Hide resolved
inc/admin.php Outdated Show resolved Hide resolved
inc/admin.php Outdated Show resolved Hide resolved
inc/admin.php Outdated Show resolved Hide resolved
Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, you can fix the textdomain issues and it's good to go.

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit ca0264e into development Sep 20, 2024
4 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the refactor/product-attach-metabox branch September 20, 2024 06:41
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 33.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants