-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: product metabox for fields attach #382
Merged
Soare-Robert-Daniel
merged 1 commit into
development
from
refactor/product-attach-metabox
Sep 20, 2024
Merged
refactor: product metabox for fields attach #382
Soare-Robert-Daniel
merged 1 commit into
development
from
refactor/product-attach-metabox
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soare-Robert-Daniel
force-pushed
the
refactor/product-attach-metabox
branch
from
September 18, 2024 15:33
83281e9
to
5ca96af
Compare
Soare-Robert-Daniel
added
the
pr-checklist-skip
Allow this Pull Request to skip checklist.
label
Sep 18, 2024
pirate-bot
added
the
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
label
Sep 18, 2024
Soare-Robert-Daniel
force-pushed
the
refactor/product-attach-metabox
branch
from
September 18, 2024 15:45
5ca96af
to
8ecc515
Compare
HardeepAsrani
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, you can fix the textdomain issues and it's good to go.
Soare-Robert-Daniel
force-pushed
the
refactor/product-attach-metabox
branch
from
September 19, 2024 08:21
8ecc515
to
06341e8
Compare
Soare-Robert-Daniel
force-pushed
the
refactor/product-attach-metabox
branch
from
September 19, 2024 08:23
06341e8
to
9be5ec9
Compare
🎉 This PR is included in version 33.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Indicate that an issue has been resolved and released in a particular version of the product.
label
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
pr-checklist-skip
Allow this Pull Request to skip checklist.
released
Indicate that an issue has been resolved and released in a particular version of the product.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Made the interface look like the one from PRO for PPOM in the product meta box.
Will affect visual aspect of the product
YES
Screenshots
Test instructions
PPOM Fields
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/ppom-pro/issues/395