Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete non-img file btn and workflow #345

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 4, 2024

Summary

  • Fixed the delete button for non-image files
  • Simplified the workflow for deletion (migrating from jQuery)

Will affect visual aspect of the product

YES

Screenshots

2024-09-04_16-59-17.mp4

Test instructions

  • Use a File Input Field
  • Add an image and non-img file (like zip)
  • Check the delete button.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/ppom-pro/issues/422

@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 4, 2024

Plugin build for 65f35ac is ready 🛎️!

js/file-upload.js Outdated Show resolved Hide resolved
inc/files.php Outdated Show resolved Hide resolved
inc/files.php Outdated Show resolved Hide resolved
Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left a couple of small changes.

@AndreeaCristinaRadacina
Copy link

It works as expected, @Soare-Robert-Daniel! Thank you for taking care.

I'll wait for the other issues before moving it to Ready to merge.

Copy link
Collaborator

@carlalexander carlalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add beyond what @HardeepAsrani already highlighted. Once he's ok with it, we're good to go! 🚀

inc/files.php Show resolved Hide resolved
@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Sep 17, 2024
inc/files.php Outdated Show resolved Hide resolved
inc/files.php Outdated Show resolved Hide resolved
@Soare-Robert-Daniel Soare-Robert-Daniel added pr-checklist-skip Allow this Pull Request to skip checklist. labels Sep 17, 2024
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Sep 17, 2024
Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, just a couple of smaller things left.

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 83145d0 into development Sep 17, 2024
4 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/file-delete branch September 17, 2024 10:44
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 33.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants