-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: delete non-img file btn and workflow #345
Conversation
969cd36
to
d956c4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, left a couple of small changes.
It works as expected, @Soare-Robert-Daniel! Thank you for taking care. I'll wait for the other issues before moving it to Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add beyond what @HardeepAsrani already highlighted. Once he's ok with it, we're good to go! 🚀
d956c4d
to
99069f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, just a couple of smaller things left.
99069f2
to
65f35ac
Compare
🎉 This PR is included in version 33.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Will affect visual aspect of the product
YES
Screenshots
2024-09-04_16-59-17.mp4
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/ppom-pro/issues/422