Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add max image selection constrain to Image Field #344

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 3, 2024

Summary

I added the functionality for the UI to restrict the selection when constraints are present. It works well with the Shift+Click combo.

Will affect visual aspect of the product

NO

Screenshots

2024-09-03_17-27-49.mp4

Test instructions

  • Add an Image Field and set the maximum number for selection
  • The UI should reflect the maximum selection.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/ppom-pro/issues/343

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 3, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Sep 3, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review September 3, 2024 14:33
@pirate-bot
Copy link
Contributor

Plugin build for 66bf9e8 is ready 🛎️!

Copy link
Collaborator

@carlalexander carlalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here 👍

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small observation but nothing important. All looks good with jQuery converted to vanilla JS. 🚀

@selul selul merged commit 74811ae into development Sep 23, 2024
13 checks passed
@selul selul deleted the fix/max-img-selection branch September 23, 2024 12:11
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 33.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added released Indicate that an issue has been resolved and released in a particular version of the product. pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants