Load necessary google charts packages in Gutenberg #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrigoreMihai
approved these changes
Feb 15, 2024
|
@Soare-Robert-Daniel Tested and the issue is fixed ✅ |
|
🎉 This PR is included in version 3.10.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added the necessary packages as parameters for the Charts component from React Google Chart lib.
Notes
This took some time to debug. At first, it might be a problem with the given data to the component since it throws an undefined error. After some extensive testing, it was not the case.
After reviewing the documents, I found that packages might not be loaded (like
geochart). After trying a bunch of things, I looked more deeply at the lib source code and found this default:https://github.com/rakannimer/react-google-charts/blob/418ebc924f36ba32eea48d79034a418042139c9e/src/hooks/useLoadGoogleCharts.ts#L23
By default, the lib does not load all necessary packages for us (like here )
Screenshots
Testing