Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webhooks integration #985

Merged
merged 24 commits into from
Jul 12, 2024
Merged

Add Webhooks integration #985

merged 24 commits into from
Jul 12, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jul 8, 2024

Summary

Added webhooks as an option to share posts.

Screenshots

Tab view

image

Popup

image

image

Instant sharing

image

Demo

2024-07-09_12-54-24.mp4

Testing

Note

You will need a webhooks service.

Warning

To test the functionality use https://github.com/Codeinwp/tweet-old-post-pro/pull/537

  1. Add the webhook via Popup
  2. Share on post.
  3. Check if the data is received.

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 8, 2024

Plugin build for c5dd746 is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jul 8, 2024
@selul
Copy link
Contributor

selul commented Jul 9, 2024

for testing and also mentioninig in the documentation, this might be handy https://webhook.site/

@selul
Copy link
Contributor

selul commented Jul 10, 2024

@Soare-Robert-Daniel is this ready? I've tried to test and I get this error:

[10-Jul-2024 16:56:54 UTC] PHP Fatal error:  Uncaught Error: Call to undefined method Rop_Webhook_Service::sign_in_url() in /Users/selul/Sites/rop/wp-content/plugins/tweet-old-post/includes/admin/class-rop-rest-api.php:877
Stack trace:
#0 /Users/selul/Sites/rop/wp-content/plugins/tweet-old-post/includes/admin/class-rop-rest-api.php(83): Rop_Rest_Api->get_service_sign_in_url(Array)
#1 /Users/selul/Sites/rop/wp-includes/rest-api/class-wp-rest-server.php(1230): Rop_Rest_Api->api(Object(WP_REST_Request))
#2 /Users/selul/Sites/rop/wp-includes/rest-api/class-wp-rest-server.php(1063): WP_REST_Server->respond_to_request(Object(WP_REST_Request), '/tweet-old-post...', Array, NULL)
#3 /Users/selul/Sites/rop/wp-includes/rest-api/class-wp-rest-server.php(439): WP_REST_Server->dispatch(Object(WP_REST_Request))
#4 /Users/selul/Sites/rop/wp-includes/rest-api.php(428): WP_REST_Server->serve_request('/tweet-old-post...')
#5 /Users/selul/Sites/rop/wp-includes/class-wp-hook.php(324): rest_api_loaded(Object(WP))
#6 /Users/selul/Sites/rop/wp-includes/class-wp-hook.php(348):  in /Users/selul/Sites/rop/wp-content/plugins/tweet-old-post/includes/admin/class-rop-rest-api.php on line 877


@Soare-Robert-Daniel
Copy link
Contributor Author

@selul did you check it with this https://github.com/Codeinwp/tweet-old-post-pro/pull/537 ?

@selul
Copy link
Contributor

selul commented Jul 11, 2024

@Soare-Robert-Daniel yes I do and you can easily check that the file has no method sign_in_url https://github.com/Codeinwp/tweet-old-post/blob/feat/webhooks/includes/admin/services/class-rop-webhook-service.php

Have you missed to push something?

@selul
Copy link
Contributor

selul commented Jul 12, 2024

Tested and is working great.

@selul selul merged commit 47b59a3 into development Jul 12, 2024
5 of 6 checks passed
@Soare-Robert-Daniel
Copy link
Contributor Author

For future references: #995

@Soare-Robert-Daniel Soare-Robert-Daniel deleted the feat/webhooks branch July 12, 2024 07:34
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 9.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants