Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed upsell message #340

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: changed upsell message #340

merged 1 commit into from
Apr 3, 2024

Conversation

preda-bogdan
Copy link
Contributor

@preda-bogdan preda-bogdan commented Feb 28, 2024 •
edited
Loading

Summary

Updated the upsell message for the Starter Site Onboarding.
These changes also work well with this PR: https://github.com/Codeinwp/themeisle/pull/1628 for conditional displaying pricing.

Test instructions

  1. Check the upsell mesages
  2. Check that on themeisle staging the following URL format will only display 2 items inside the pricing table: https://fmbklha76y-staging.onrocket.site/themes/neve/upgrade/?utm_source=wpadmin&utm_medium=admin&utm_campaign=onboarding_upsell&utm_content=neve#pricing

Closes #330.

@pirate-bot
Copy link
Collaborator

Plugin build for 3a76882 is ready 🛎️!

@preda-bogdan preda-bogdan linked an issue Feb 28, 2024 that may be closed by this pull request
Change update message in onboarding of starter sites #330
Closed
@preda-bogdan preda-bogdan added the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 14, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Mar 14, 2024
@irinelenache
Copy link

@preda-bogdan Tested and everything's fine here 🚀

@vytisbulkevicius vytisbulkevicius merged commit 6f117a2 into development Apr 3, 2024
8 of 9 checks passed
@vytisbulkevicius vytisbulkevicius deleted the fix/upsell_message branch April 3, 2024 07:12
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 1.2.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soare-Robert-Daniel Soare-Robert-Daniel Soare-Robert-Daniel approved these changes

Assignees
No one assigned
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change update message in onboarding of starter sites
5 participants
@preda-bogdan @pirate-bot @irinelenache @Soare-Robert-Daniel @vytisbulkevicius