Fse template import

[cristian-ungureanu]

Summary

• Implemented the FSE Template import inside the templates cloud

Note

For the images to be properly saved, the website needs to be public, else it will default to a placeholder image when saving the template.

Screenshots

FSE Library

FSE Import

Test instructions

1. Use this version of the plugin
2. Use a FSE Theme
3. From the FSE Editor, save a template for the Front Page or any other page
4. Check that the template is visible inside My Library
5. Check that the Preview is visible before importing inside the Editor
6. Import the template on a different FSE Theme

Closes #255.

[pirate-bot]

Plugin build for dacb33d is ready 🛎️!

• Download build

[preda-bogdan]

I started the review process here, however I ran into a few issues when trying to replicate the stack. Will follow up wit the review as there are a few things to cover.

Until then I have a question about the implementation, wouldn't this also require changes on the Templates Cloud endpoint?

[cristian-ungureanu]

Thank you, Bogdan. There were only some minor changes on the server, no PR for now. I only needed to change https://github.com/Codeinwp/store-themeisle/blob/master/web/app/plugins/templates-cloud/inc/class-db-table.php#L173 with

		if ( ! empty( $args['type'] ) ) {
			// Try to decode it.
			$decoded_array = json_decode( $args['type'], true );
			if ( ! empty( $decoded_array ) && is_array( $decoded_array ) ) {
				$args['type'] = $decoded_array;
			}

[preda-bogdan]

We decided to do some changes to ensure it is easier to test for the QA and do the review after the changes are finished.

[preda-bogdan]

I modified the code so that no other changes are required on the templates-cloud service, it will use the same existing infrastructure.

[Soare-Robert-Daniel]

Looking good. NIT: some console logs used for debugging left in the code

[irinelenache]

@preda-bogdan Tested and the imports work as expected 🚀

Found only some small issues:

• When i'm in the importer window, the FSE toggle is activated and i use the sync button, the FSE templates won't be visible until i deactivate and reactivate the FSE toggle. Here is a video with the behaviour https://vertis.d.pr/v/SOMEtQ
• When I import a template, the header and footer are also imported, and they appear as groups instead of template parts https://vertis.d.pr/i/4o5QEj . I would expect either to import the content only, without the header and footer, or to import the whole page, header and footer included, but those to be marked as template parts.

[preda-bogdan]

@irinelenache I've solved the issue with the toggle not counting on refresh, for the second issue we discussed it on our team and we decided it is the expected behavior for now and we can revisit it once we gather some more feedback from our users.

Once you have another look, let me know if everything is working as expected.

Thank you!

[irinelenache]

@preda-bogdan Tested and everything's fine now 🚀

[pirate-bot]

🎉 This PR is included in version 1.2.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀