Replace strings and spacing in old patterns #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed duplicate pattern slug
fixed indentation
fixed syntax
fixed syntax
fixed syntax
fix syntax
fix syntax
fix syntax
fix syntax
fix syntax
fix syntax
fix syntax
|
@HardeepAsrani I eventually managed to rework our old patterns as well for consistency. I replaced all the text strings with the string variables, and also applied the new spacing vars in paddings, instead of inline px values. I managed NOT to have any rendering issues for these ones 🚀 . You can view all patterns now in the pattern library of the demo site, but overall they are fine. You might just want to check the markup, and that failing test. |
fixed string variable
updated strings
HardeepAsrani
approved these changes
Dec 14, 2023
|
LGTM, I've fixed the issue as well. Feel free to merge. |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces all the text strings and spacing values that we had in our old patterns, with string and spacing variables.
Will affect visual aspect of the product
NO
Test instructions