New patterns #87
New patterns #87
Conversation
Removed Singles Category and added the names for patterns.
Adjusted names of new patterns
assigned pattern to Team category
Added some more strings that were used on templates and loop patterns
added a string
Added search_button string
Had uploaded the pattern in the wrong location: inc/title-background.php
update pattern with strings and spacing
updated pattern with strings and spacing
update pattern with strings and spacing
updated strings and layout
fixed socials
fixed typo
|
Hey @HardeepAsrani , just wanted to set some perspective here if possible. I think we should prioritise with the review and merging of this PR, it has a bunch of changes, mainly the addition of new patterns and pages. We need to start consolidating things and shape-up the theme with all the final material (patterns/templates/pages) included, so we can test holistically with the onboarding. I need you to review overall, and investigate some rendering issues with 4 patterns that I have faced problems with. Other than that, things appear to be working well. Testimonial Columns with Rating
Pattern Library at the DemoIf you want, you can see the full pattern library in the demo site. Magic login here, and then go to pattern library. You should see all the patterns there, Check also the full-page patterns in the pages category. I made them composite, referencing other patterns (wherever possible), like you suggested. Homepage 2 Page Example Last but not least, I think this PR here is important to merge first, if we want to finalise the templates in this one: #85 Thanks! Please don't hesitate to ping me for any help or clarifications at any point. |
|
@JohnPixle I've fixed the resolving errors in blocks. Let me know if all is good. |
|
@HardeepAsrani Thanks, looking perfect now. Just out of curiosity, what was the problem with these patterns? I almost fried my head to debug them, but eventually gave up 😆 . Thanks anyway! |
|
@JohnPixle God knows, I just copied and pasted them back from the patterns website that you have over at instawp. So might have been something during the exporting/importing. |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Summary
All strings and images in these patterns reference the variables we have created for strings.
Will affect visual aspect of the product
NO
Test instructions
Closes #.