Define text strings in core.php #86
Conversation
As discussed in Slack, I added the strings and thefunction here.
added names of new patterns
Just a test to see if the code and string definitions are correct.
|
@HardeepAsrani fyi, I have done what we discussed in this PR. I added the strings in core.php, created a function, and then I added a new pattern as a test. let me know if things work! |
fixed mistake in category definition
There was a problem hiding this comment.
It looks good and I tested it to work. Few changes I made here is to fix spacing as I saw the files that you edited converted it to space from existing tabs.
In future, you can run a command in your editor (for ex VS Code) to convert all indentations to tabs automatically.
Secondly, I fixed all the PHPCS error. I recommend you to use VSCode or git directly so you can see the PHPCS errors if any. They were mostly basic and related to inline documentation.
|
Thanks for the insights here. I will merge this now 🚀 |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Summary
Following our discussion in Slack, I added the global strings in the core.php file, and I also created the function. Please review and merge if everything is good to go.
Will affect visual aspect of the product
NO