Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace font families #80

Merged
merged 11 commits into from
Nov 23, 2023
Merged

Replace font families #80

merged 11 commits into from
Nov 23, 2023

Conversation

JohnPixle
Copy link
Contributor

@JohnPixle JohnPixle commented Nov 23, 2023

Summary

Replaces Inter and Jet Brains families with Spline Sans and Spline Sans Mono. Also fixes some typo issues that were preventing fonts to be rendered properly.

Will affect visual aspect of the product

Yes, in theme style presets.

Test instructions

Closes #.

@JohnPixle JohnPixle changed the base branch from master to development November 23, 2023 11:25
@pirate-bot
Copy link
Contributor

Plugin build for 0942870 is ready 🛎️!

@pirate-bot
Copy link
Contributor

Plugin build for fab1847 is ready 🛎️!

Fix typo in font family path
@pirate-bot
Copy link
Contributor

Plugin build for a529cb0 is ready 🛎️!

@pirate-bot
Copy link
Contributor

Plugin build for 1542dbf is ready 🛎️!

@pirate-bot
Copy link
Contributor

Plugin build for c4cab11 is ready 🛎️!

@pirate-bot
Copy link
Contributor

Plugin build for 3d96838 is ready 🛎️!

@pirate-bot
Copy link
Contributor

Plugin build for 533d466 is ready 🛎️!

@JohnPixle
Copy link
Contributor Author

This one is working great with the new fonts and everything, just tested it. Merging with development.

@JohnPixle JohnPixle merged commit 945402e into development Nov 23, 2023
6 of 7 checks passed
@HardeepAsrani
Copy link
Member

@JohnPixle If you have some elements where you've added specified the fonts already, won't this change break those?

@JohnPixle
Copy link
Contributor Author

@HardeepAsrani No it's fine, I had not used the replaced families anywhere, only in the new theme style presets I created. It works fine, just tested. Thanks for checking-in however!

@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants