Re order color palette and add dark bg #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add dark bg
add dark bg
fix value
add dark bg
add bg color
add dark bg
add dark bg
|
I just tested it on my instance and it's all good Hardeep ✌🏻 |
HardeepAsrani
approved these changes
Nov 21, 2023
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR i have re-ordered the color palette in order to achieve the primary and secondary accent colors to appear in the theme style preset thumbnail. Similar to what we had done in Neve FSE. Simply added primary and secondary to the 3rd and 4th position.
Additionally, I have included a new color variable for dark background, like we have in our other themes. I have done this for all existing theme style presets.
Lastly, improved the semantic naming of color variables:
Foreground >> Text
Background Dark >> Dark Background
Background Alt >> Light Background
Foreground alt >> Inverted text
Will affect visual aspect of the product
Yes, but not directly, the new dark bg color is not being used anywhere, and additionally there has been no slug change.
Screenshots
Test instructions
Open the site editor, the primary and secondary accent colors should be visible on the thumbnails.
Additionally, a new slot for the dark bg color should be available in each style preset.
Closes #76