Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development #106

Merged
merged 15 commits into from
Feb 14, 2024
Merged

Development #106

merged 15 commits into from
Feb 14, 2024

Conversation

HardeepAsrani
Copy link
Member

pirate-bot and others added 14 commits December 19, 2023 17:58
@pirate-bot
Sync branch [skip ci]
0d47c2d
@pirate-bot
Sync branch [skip ci]
84ef147
@dependabot
chore(deps-dev): bump squizlabs/php_codesniffer from 3.8.0 to 3.8.1
8a88c2d 
Bumps [squizlabs/php_codesniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) from 3.8.0 to 3.8.1.
- [Release notes](https://github.com/PHPCSStandards/PHP_CodeSniffer/releases)
- [Changelog](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/CHANGELOG.md)
- [Commits](PHPCSStandards/PHP_CodeSniffer@3.8.0...3.8.1)

---
updated-dependencies:
- dependency-name: squizlabs/php_codesniffer
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@HardeepAsrani
fix: nps compare sign
3abca1d
@HardeepAsrani
Update Admin.php
c23bdc4
@HardeepAsrani
fix: add logo option to onboarding
df18616
@HardeepAsrani
chore: update message
93e3664
@dependabot
chore(deps): bump codeinwp/themeisle-sdk from 3.3.11 to 3.3.13
916d1ba 
Bumps [codeinwp/themeisle-sdk](https://github.com/Codeinwp/themeisle-sdk) from 3.3.11 to 3.3.13.
- [Release notes](https://github.com/Codeinwp/themeisle-sdk/releases)
- [Changelog](https://github.com/Codeinwp/themeisle-sdk/blob/master/CHANGELOG.md)
- [Commits](Codeinwp/themeisle-sdk@v3.3.11...v3.3.13)

---
updated-dependencies:
- dependency-name: codeinwp/themeisle-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@HardeepAsrani
chore: update notice
5116338
@HardeepAsrani
Merge pull request #102 from Codeinwp/dependabot/composer/development…
224e743 
…/squizlabs/php_codesniffer-3.8.1

chore(deps-dev): bump squizlabs/php_codesniffer from 3.8.0 to 3.8.1
@HardeepAsrani
Merge pull request #104 from Codeinwp/dependabot/composer/development…
e95215b 
…/codeinwp/themeisle-sdk-3.3.13

chore(deps): bump codeinwp/themeisle-sdk from 3.3.11 to 3.3.13
@HardeepAsrani
Merge pull request #105 from Codeinwp/development
28fe052 
Development
@HardeepAsrani
fix: phpcs
af1cc60
@HardeepAsrani
Merge pull request #103 from Codeinwp/fix/issue-141
ecc39b2 
fix: add logo option to onboarding
@pirate-bot
Copy link
Contributor

Plugin build for ecc39b2 is ready 🛎️!

@JohnPixle
Copy link
Contributor

@HardeepAsrani Thanks for the update, I just tested but need to do some changes:

  1. The copy on the banner is not the final one. It should be this one.
Thanks for downloading Raft Theme 🎉

Extend Raft with our Free Builder
Install our free builder plugin for more blocks, enhanced functionality, and seamless theme setup. Learn more.

[ Download Otter Builder ]
  1. If I remember correctly, we had agreed to remove the Otter logo from the wizard steps, and replace it with Raft's logo.
    Screenshot 2024-02-06 at 11 03 47 AM

Let me know if you need any help!

@HardeepAsrani
Copy link
Member Author

@JohnPixle I just copied them from Figma so I suppose I picked the wrong one, I've fixed that. I've kept the button text to Install Otter instead of Download, let me know if that's fine.

  1. You need to use the Otter PR to see the logo changes as that code is part of Otter, not Raft.

@pirate-bot
Copy link
Contributor

Plugin build for 086f216 is ready 🛎️!

@JohnPixle
Copy link
Contributor

@HardeepAsrani thanks, I got it working.

Just 2 notes:

  1. The Learn more link in the banner should link to the Otter plugin page, not the docs.

  2. In the first step, the Raft logo is a bit huge. Can we set the width to 80px please? In the next steps the logo size is fine.

Everything else is good, thanks for taking care of these.

@JohnPixle
Copy link
Contributor

@HardeepAsrani btw, I noticed that after initiating the wizard, I get some errors. Something to look into, or it is expected due to the PRs?

 Admin area URL: https://arrivesoup.s1-tastewp.com/wp-admin 
 Username: pixle 
 Password: ieR-jg8MRfg

Screenshot 2024-02-06 at 11 49 18 AM

@HardeepAsrani
Copy link
Member Author

Based on the errors, I'm guessing you download Otter Dev build while also having Otter WPorg build installed. :)

@HardeepAsrani
Copy link
Member Author

^ @JohnPixle

@JohnPixle
Copy link
Contributor

JohnPixle commented Feb 6, 2024 •
edited
Loading

@HardeepAsrani sort of.

  • I start by having no Otter installed.
  • Then I upload the Dev Build
  • When I click the banner button, it downloads the otter build from the repo.
    I end up with two otter versions (build and wporg)

I am not sure how to bypass that.

 Admin area URL: https://arrivesoup.s1-tastewp.com/wp-admin 
 Username: pixle 
 Password: ieR-jg8MRfg

Screenshot 2024-02-06 at 12 10 56 PM

@HardeepAsrani
Copy link
Member Author

@JohnPixle You can download the production build from the PR instead of dev.

@HardeepAsrani HardeepAsrani merged commit 7b229dc into master Feb 14, 2024
5 checks passed
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 1.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HardeepAsrani @pirate-bot @JohnPixle