Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/formbricks #2402

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Fix/formbricks #2402

merged 3 commits into from
Oct 8, 2024

Conversation

HardeepAsrani
Copy link
Member

Closes #2393.

Summary

This updates the Formbricks package to make sure the notice still shows up.

Screenshots


Test instructions

  • Install Otter plugin
  • Modify otter_blocks_install unix timestamp value to be at least 2 days old in wp_options table
  • Check if Survey appears on Otter pages
  • You can also add &formbricksDebug=true to the URL of the Otter dashboard to see logs in the console.

@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Oct 8, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 8, 2024
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 271.38 KB 271.38 KB 0 B (0.00%)
Blocks 1.56 MB 1.56 MB 0 B (0.00%)
CSS 100.87 KB 100.87 KB 0 B (0.00%)
Dashboard 219.93 KB 198.32 KB -21.61 KB (-9.83%)
Onboarding 161.11 KB 161.11 KB 0 B (0.00%)
Export Import 97.78 KB 97.78 KB 0 B (0.00%)
Pro 422.93 KB 422.93 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for 97ef61f is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 243.95, firstPaint: 480.9, domContentLoaded: 1547.3, loaded: 1548.15, firstContentfulPaint: 3527.35, firstBlock: 7862.1, type: 13.84, minType: 11.75, maxType: 25.21, typeContainer: 9.27, minTypeContainer: 7.99, maxTypeContainer: 11.38, focus: 31.53, minFocus: 29.36, maxFocus: 37.76, inserterOpen: 23.41, minInserterOpen: 20.79, maxInserterOpen: 30.31, inserterSearch: 0.9, minInserterSearch: 0.79, maxInserterSearch: 1.08, inserterHover: 3.24, minInserterHover: 2.69, maxInserterHover: 4.01, listViewOpen: 150.68, minListViewOpen: 134.65, maxListViewOpen: 166.06

@vytisbulkevicius vytisbulkevicius merged commit d4ba66c into development Oct 8, 2024
12 checks passed
@vytisbulkevicius vytisbulkevicius deleted the fix/formbricks branch October 8, 2024 15:15
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants