Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed border width and border radius issue #2377

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Conversation

girishpanchal30
Copy link
Contributor

Closes #2373

Summary

In this PR, I've resolved the issue with border style units in the BoxControl component.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 24, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Sep 24, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 24, 2024

Plugin build for ba8673b is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 24, 2024

Bundle Size Diff

Package Old Size New Size Diff
Animations 271.38 KB 271.38 KB 0 B (0.00%)
Blocks 1.56 MB 1.56 MB 0 B (0.00%)
CSS 100.87 KB 100.87 KB 0 B (0.00%)
Dashboard 219.93 KB 219.93 KB 0 B (0.00%)
Onboarding 161.11 KB 161.11 KB 0 B (0.00%)
Export Import 97.78 KB 97.78 KB 0 B (0.00%)
Pro 422.93 KB 422.93 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 24, 2024

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 243, firstPaint: 479.6, domContentLoaded: 1575.2, loaded: 1575.95, firstContentfulPaint: 3583.4, firstBlock: 7989.25, type: 13.33, minType: 12.22, maxType: 14.57, typeContainer: 9.06, minTypeContainer: 7.91, maxTypeContainer: 10.79, focus: 32.9, minFocus: 29.65, maxFocus: 38.41, inserterOpen: 22.1, minInserterOpen: 20.23, maxInserterOpen: 25.12, inserterSearch: 0.93, minInserterSearch: 0.79, maxInserterSearch: 1.1, inserterHover: 3.26, minInserterHover: 2.73, maxInserterHover: 4.67, listViewOpen: 148.92, minListViewOpen: 138.6, maxListViewOpen: 160.79

@selul selul removed the request for review from Soare-Robert-Daniel October 1, 2024 06:32
@HardeepAsrani HardeepAsrani merged commit e825625 into development Oct 3, 2024
8 of 9 checks passed
@HardeepAsrani HardeepAsrani deleted the bugfix/2373 branch October 3, 2024 19:58
@HardeepAsrani HardeepAsrani mentioned this pull request Oct 3, 2024
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants