Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Timeline block #2329

Merged
merged 2 commits into from
Aug 7, 2024
Merged

feat: add Timeline block #2329

merged 2 commits into from
Aug 7, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Aug 6, 2024

Closes https://github.com/Codeinwp/otter-internals/issues/177

Summary

Added the initial implementation for Timeline Block

Screenshots

image

image

image


Test instructions

  1. Inser the Timeline Block
  2. Customize
  3. Check if everything is working

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Aug 6, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review August 6, 2024 13:00
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 263.56 KB 265.98 KB 2.42 KB (0.92%)
Blocks 1.51 MB 1.53 MB 15.07 KB (0.97%)
CSS 93.26 KB 95.67 KB 2.42 KB (2.59%)
Dashboard 203.99 KB 207.22 KB 3.23 KB (1.58%)
Onboarding 153.22 KB 155.64 KB 2.42 KB (1.58%)
Export Import 90.28 KB 92.7 KB 2.42 KB (2.68%)
Pro 365.35 KB 367.76 KB 2.42 KB (0.66%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 6, 2024

Plugin build for 5544075 is ready 🛎️!

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left few small things here and there. Good work, the block works great.

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 6, 2024

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 236.5, firstPaint: 162.75, domContentLoaded: 1585, loaded: 1585.75, firstContentfulPaint: 3534.95, firstBlock: 7918.25, type: 13.41, minType: 11, maxType: 17.44, typeContainer: 8.61, minTypeContainer: 7.52, maxTypeContainer: 10.46, focus: 33.59, minFocus: 29.36, maxFocus: 41.35, inserterOpen: 22.06, minInserterOpen: 19.8, maxInserterOpen: 25.37, inserterSearch: 0.71, minInserterSearch: 0.61, maxInserterSearch: 0.9, inserterHover: 4.04, minInserterHover: 2.63, maxInserterHover: 19.37, listViewOpen: 146.47, minListViewOpen: 131.4, maxListViewOpen: 173.09

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 6, 2024
@HardeepAsrani HardeepAsrani merged commit 24aac67 into development Aug 7, 2024
11 of 12 checks passed
@HardeepAsrani HardeepAsrani deleted the feat/timeline-block-3 branch August 7, 2024 10:01
@carlalexander
Copy link
Collaborator

@Soare-Robert-Daniel didn't get to review before the merge, but I'd have merged the test commit into the feat one since it's a test for that feature.

@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants