-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Timeline block #2329
feat: add Timeline block #2329
Conversation
Bundle Size Diff
|
Plugin build for 5544075 is ready 🛎️!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left few small things here and there. Good work, the block works great.
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 236.5, firstPaint: 162.75, domContentLoaded: 1585, loaded: 1585.75, firstContentfulPaint: 3534.95, firstBlock: 7918.25, type: 13.41, minType: 11, maxType: 17.44, typeContainer: 8.61, minTypeContainer: 7.52, maxTypeContainer: 10.46, focus: 33.59, minFocus: 29.36, maxFocus: 41.35, inserterOpen: 22.06, minInserterOpen: 19.8, maxInserterOpen: 25.37, inserterSearch: 0.71, minInserterSearch: 0.61, maxInserterSearch: 0.9, inserterHover: 4.04, minInserterHover: 2.63, maxInserterHover: 19.37, listViewOpen: 146.47, minListViewOpen: 131.4, maxListViewOpen: 173.09 |
9533e71
to
5544075
Compare
@Soare-Robert-Daniel didn't get to review before the merge, but I'd have merged the |
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes https://github.com/Codeinwp/otter-internals/issues/177
Summary
Added the initial implementation for Timeline Block
Screenshots
Test instructions
Checklist before the final review