Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add merge fields for Mailchimp #2323

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Aug 5, 2024

Closes https://github.com/Codeinwp/otter-internals/issues/168

Summary

Added the ability to link the value of the fields with some of the types for Mailchimp Merge Fields

Note

The users are advised to mostly use the type TEXT for the linked fields.

Fields like File do not file, but the name of the files. Select type fields (e.g., checkbox) and send a string of values with the selected types.

This is not made to handle complex cases, uploading files to Mailchimp, and advanced selection to their dropdown.

image

Warning

The validation is disabled, so wrong data might be sent if the Otter field is not properly set up based on the merge fields.

Screenshots

Merge fields in Mailchimp Dashboard

image

Connected Otter fields

image

image

Mailchimp Contact list with extra fields

image


Test instructions

Check if the tag in the Otter field MAPPED NAMED is sent to its corresponding tag in Mailchimp MERGE FIELDS.

Note

We only send the data to Mailchimp. Do not expect to send automatic replays with merged fields from the plugin -- this is done via Mailchimp if it is set up to do so.

References:

image


Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Aug 5, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 5, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review August 5, 2024 15:17
@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 5, 2024

Bundle Size Diff

Package Old Size New Size Diff
Animations 265.96 KB 265.96 KB 0 B (0.00%)
Blocks 1.53 MB 1.53 MB 26 B (0.00%)
CSS 95.66 KB 95.66 KB 0 B (0.00%)
Dashboard 207.2 KB 207.2 KB 0 B (0.00%)
Onboarding 155.62 KB 155.62 KB 0 B (0.00%)
Export Import 92.68 KB 92.68 KB 0 B (0.00%)
Pro 383.13 KB 383.15 KB 24 B (0.01%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 5, 2024

Plugin build for 8af9f77 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 5, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 5, 2024

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 233.45, firstPaint: 146.35, domContentLoaded: 1561.75, loaded: 1562.45, firstContentfulPaint: 3443.55, firstBlock: 7649.75, type: 12.44, minType: 10.32, maxType: 17.06, typeContainer: 8.87, minTypeContainer: 7.74, maxTypeContainer: 12.94, focus: 32.74, minFocus: 28.33, maxFocus: 43.69, inserterOpen: 23.01, minInserterOpen: 19.4, maxInserterOpen: 33.22, inserterSearch: 0.71, minInserterSearch: 0.61, maxInserterSearch: 0.84, inserterHover: 3.58, minInserterHover: 2.62, maxInserterHover: 5.35, listViewOpen: 147.38, minListViewOpen: 134.38, maxListViewOpen: 161.16

@ineagu ineagu added the doc-needed This issue requires documentation updates or additions once it has been completed. label Aug 6, 2024
@ineagu
Copy link
Contributor

ineagu commented Aug 6, 2024

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit c3002ad into development Aug 7, 2024
9 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/column-width branch August 7, 2024 12:00
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-needed This issue requires documentation updates or additions once it has been completed. pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants