Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tiled style to Posts Block #2322

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

HardeepAsrani
Copy link
Member

Closes https://github.com/Codeinwp/otter-internals/issues/218.

Summary

Added a tiled style with overlay color and image as the background of the tiles as a new style to Posts Block.

Screenshots

Screenshot 2024-08-04 at 11 48 49 AM

Test instructions

  • Just confirm everything works fine with the new style.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

Added a tiled style with overlay color and image as background of the
tiles as a new style to Posts Block.

Closes Codeinwp/otter-internals#218
@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 4, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 4, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 4, 2024

Bundle Size Diff

Package Old Size New Size Diff
Animations 263.53 KB 263.56 KB 33 B (0.01%)
Blocks 1.51 MB 1.51 MB 1.43 KB (0.09%)
CSS 93.23 KB 93.26 KB 33 B (0.03%)
Dashboard 201.81 KB 201.84 KB 33 B (0.02%)
Onboarding 153.19 KB 153.22 KB 33 B (0.02%)
Export Import 90.25 KB 90.28 KB 33 B (0.04%)
Pro 365.27 KB 365.3 KB 33 B (0.01%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 4, 2024

Plugin build for 837b6e9 is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 4, 2024

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 233.3, firstPaint: 149.7, domContentLoaded: 1537.15, loaded: 1538.05, firstContentfulPaint: 3423.5, firstBlock: 7558.2, type: 11.79, minType: 10.43, maxType: 13.12, typeContainer: 8.34, minTypeContainer: 7.73, maxTypeContainer: 9.97, focus: 31.21, minFocus: 27.52, maxFocus: 40.9, inserterOpen: 21.31, minInserterOpen: 19.56, maxInserterOpen: 25.72, inserterSearch: 0.71, minInserterSearch: 0.57, maxInserterSearch: 0.9, inserterHover: 3.08, minInserterHover: 2.69, maxInserterHover: 3.9, listViewOpen: 142.6, minListViewOpen: 130.58, maxListViewOpen: 159.64

Adds an option to Image element panel to set the image ratio, with the
default set to inherit.
@HardeepAsrani HardeepAsrani merged commit 216b7a4 into development Aug 6, 2024
11 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/issue-218 branch August 6, 2024 03:20
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants