Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more selectors for Advanced Heading #2301

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

HardeepAsrani
Copy link
Member

Closes #2299.

Summary

Adds more selectors to make sure Heading block works better with more themes as some themes and Core has some styles that prevent the default styles from working.


Checklist before the final review

  • [] Included E2E or unit tests for the changes in this PR.
  • [] Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

Adds more selectors to make sure Heading block works better with more
themes as some themes and Core has some styles that prevent the default
styles from working.

Closes #2299
@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 1, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 1, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 1, 2024

Bundle Size Diff

Package Old Size New Size Diff
Animations 263.53 KB 263.53 KB 0 B (0.00%)
Blocks 1.51 MB 1.51 MB 0 B (0.00%)
CSS 93.23 KB 93.23 KB 0 B (0.00%)
Dashboard 201.77 KB 201.77 KB 0 B (0.00%)
Onboarding 153.19 KB 153.19 KB 0 B (0.00%)
Export Import 90.25 KB 90.25 KB 0 B (0.00%)
Pro 365.23 KB 365.23 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 1, 2024

Plugin build for c1a9256 is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 1, 2024

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 248.65, firstPaint: 166.35, domContentLoaded: 1618.7, loaded: 1619.6, firstContentfulPaint: 3669.4, firstBlock: 8111.55, type: 13.52, minType: 12.03, maxType: 17.13, typeContainer: 9.46, minTypeContainer: 7.87, maxTypeContainer: 11.6, focus: 37.34, minFocus: 32.12, maxFocus: 45.18, inserterOpen: 25.28, minInserterOpen: 23.2, maxInserterOpen: 31.3, inserterSearch: 0.74, minInserterSearch: 0.63, maxInserterSearch: 0.86, inserterHover: 4.4, minInserterHover: 2.8, maxInserterHover: 15.46, listViewOpen: 152.12, minListViewOpen: 138.66, maxListViewOpen: 169.9

@HardeepAsrani HardeepAsrani merged commit 0eef0ae into development Aug 2, 2024
9 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/issue-2299 branch August 2, 2024 19:08
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants