Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: various small changes #2275

Merged
merged 1 commit into from
Jul 30, 2024
Merged

chore: various small changes #2275

merged 1 commit into from
Jul 30, 2024

Conversation

HardeepAsrani
Copy link
Member

@HardeepAsrani HardeepAsrani commented Jul 25, 2024

Closes https://github.com/Codeinwp/otter-internals/issues/173.

Summary

  • Rename Slider to Image Slider
  • Remove notice from Countdown Block
  • Change upsell notice color to Gray
  • Remove Upsell from Form sidebar
  • Add Pro label to Form Submission menu item
  • Remove Export button from Form Submission page for in free version
  • Rename sib to Brevo
  • Remove CTA category, use the default one
  • Replace webhook docs link
  • Set default Countdown date

Screenshots


Test instructions


Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

- Rename Slider to Image Slider
- Remove notice from Countdown Block
- Change upsell notice color to Gray
- Remove Upsell from Form sidebar
- Add Pro label to Form Submission menu item
- Remove Export button from Form Submission page for in free version
- Rename sib to Brevo
- Remove CTA category, use the default one
- Replace webhook docs link
- Set default Countdown date

Closes: Codeinwp/otter-internals#173
@HardeepAsrani HardeepAsrani marked this pull request as ready for review July 25, 2024 04:00
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 264.2 KB 264.21 KB 6 B (0.00%)
Blocks 1.52 MB 1.52 MB -1.66 KB (-0.11%)
CSS 93.45 KB 93.45 KB 6 B (0.01%)
Dashboard 195.96 KB 195.78 KB -180 B (-0.09%)
Onboarding 153.89 KB 153.9 KB 6 B (0.00%)
Export Import 90.96 KB 90.96 KB 6 B (0.01%)
Pro 362.19 KB 362.3 KB 114 B (0.03%)

@pirate-bot
Copy link
Contributor

Plugin build for a1e13b5 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 239.75, firstPaint: 151.6, domContentLoaded: 1547, loaded: 1547.55, firstContentfulPaint: 3502.5, firstBlock: 6777.8, type: 11.55, minType: 10.23, maxType: 13.9, typeContainer: 8.25, minTypeContainer: 6.78, maxTypeContainer: 10.37, focus: 30.45, minFocus: 25.63, maxFocus: 40.37, inserterOpen: 23.12, minInserterOpen: 20.46, maxInserterOpen: 27.38, inserterSearch: 0.72, minInserterSearch: 0.62, maxInserterSearch: 0.89, inserterHover: 3.9, minInserterHover: 3.41, maxInserterHover: 4.82, listViewOpen: 147.94, minListViewOpen: 133.14, maxListViewOpen: 178.98

@HardeepAsrani HardeepAsrani merged commit 27bbb24 into development Jul 30, 2024
22 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/issue-173 branch July 30, 2024 18:15
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added released Indicate that an issue has been resolved and released in a particular version of the product. pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants