-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace the original block of the AI Toolbar action #2274
Conversation
Bundle Size Diff
|
Plugin build for 492c6ec is ready 🛎️!
|
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 242, firstPaint: 166.25, domContentLoaded: 1578.85, loaded: 1579.65, firstContentfulPaint: 3557.3, firstBlock: 6885.55, type: 12.05, minType: 10.4, maxType: 13.84, typeContainer: 7.79, minTypeContainer: 6.71, maxTypeContainer: 9.85, focus: 30.3, minFocus: 25.92, maxFocus: 36.01, inserterOpen: 24.42, minInserterOpen: 20.31, maxInserterOpen: 37.82, inserterSearch: 0.72, minInserterSearch: 0.59, maxInserterSearch: 0.92, inserterHover: 4, minInserterHover: 3.36, maxInserterHover: 5.02, listViewOpen: 144.96, minListViewOpen: 133.29, maxListViewOpen: 158.44 |
This looks good to me! I'm glad you added a test. I think With your test, you're looking if the original block is gone. Is it also possible to check if the text in the AI block matches the content from your mocked API request? This is more of a question. I think it'd be good to check that if we can. |
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes https://github.com/Codeinwp/otter-internals/issues/214
Summary
The origin block in which the AI actions are triggered is now linked to the AI Block created. On Replace actions, the origin block will be replaced, and the AI Block will be deleted.
Note
This works when both blocks are part of the same session. It is considered a new session if you reload the page or switch to code mode and come back.
Screenshots
2024-07-24_17-55-48.mp4
Test instructions
Note
You will need an OpenAI key.
Replace
after the AI Block generates the content.Checklist before the final review