-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve issue handlers for Form submissions #2266
Conversation
399af75
to
bc71f71
Compare
@ineagu, is this how you envisioned the logging? |
Bundle Size Diff
|
Plugin build for 1e908b2 is ready 🛎️!
|
bc71f71
to
c701ad5
Compare
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 236.45, firstPaint: 153.45, domContentLoaded: 1532.45, loaded: 1533.3, firstContentfulPaint: 3473.35, firstBlock: 7566.95, type: 12.58, minType: 11.11, maxType: 16.53, typeContainer: 8.37, minTypeContainer: 7.54, maxTypeContainer: 11.3, focus: 31.49, minFocus: 29.01, maxFocus: 35.13, inserterOpen: 22.1, minInserterOpen: 19.38, maxInserterOpen: 31.83, inserterSearch: 0.7, minInserterSearch: 0.61, maxInserterSearch: 0.82, inserterHover: 3.93, minInserterHover: 3.55, maxInserterHover: 5.34, listViewOpen: 140.95, minListViewOpen: 129.23, maxListViewOpen: 157.59 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major thing here! I found a typo.
As discussed, let's try to not use the modules with conventional commits. So just use feat:
. But otherwise, the message is clear and good 🙌
looks good to me @Soare-Robert-Daniel |
c701ad5
to
1e908b2
Compare
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes https://github.com/Codeinwp/otter-internals/issues/176
Summary
Screenshots
Erorr displayed with admin details.
Issue logged in
debug.log
We are dumbing the error along with the requested data:
Test instructions
Checklist before the final review