Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach Themeisle docs link on Mapped Name #1838

Merged
merged 2 commits into from
Sep 2, 2023
Merged

Attach Themeisle docs link on Mapped Name #1838

merged 2 commits into from
Sep 2, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Aug 30, 2023 •
edited
Loading

Closes #

Summary

Attach docs link to the Mapped Name field in Fields Blocks.

Enable the change of the mapped name in Hidden Input.

Screenshots

Test instructions

image

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 30, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Aug 30, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel changed the title feat: add docs on mapped & enable on hidden input Attach Themeisle docs link on Mapped Name Aug 30, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review August 30, 2023 12:09
@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 30, 2023 •
edited
Loading

Bundle Size Diff

Package Old Size New Size Diff
Animations 272.72 KB 272.72 KB 0 B (0.00%)
Blocks 1.45 MB 1.45 MB 98 B (0.01%)
CSS 87.22 KB 87.22 KB 0 B (0.00%)
Dashboard 124.43 KB 124.43 KB 0 B (0.00%)
Export Import 85.11 KB 85.11 KB 0 B (0.00%)
Pro 328.78 KB 329.13 KB 365 B (0.11%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 30, 2023 •
edited
Loading

Plugin build for f8d605e is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 30, 2023 •
edited
Loading

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 89.72 9.58 88.85 0 (60ms) 10.53 (80ms)
Values above 60ms "0 - 86.77, 1 - 99.65, 2 - 92.95, 3 - 84.10, 4 - 82.81, 5 - 76.77, 6 - 77.91, 7 - 88.27, 8 - 88.97, 9 - 89.13, 10 - 94.53, 11 - 119.34, 12 - 88.95, 13 - 85.12, 14 - 88.85, 15 - 104.67, 16 - 89.67, 17 - 84.49, 18 - 81.74"

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 30, 2023
@rodica-andronache
Copy link

@Soare-Robert-Daniel everything's working well 👍 tested both zapier and IFTTT

@HardeepAsrani HardeepAsrani merged commit 3af254d into next Sep 2, 2023
12 checks passed
@HardeepAsrani HardeepAsrani deleted the feat/mapped-name-docs branch September 2, 2023 10:01
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HardeepAsrani HardeepAsrani HardeepAsrani approved these changes

Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Soare-Robert-Daniel @pirate-bot @rodica-andronache @HardeepAsrani