-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add height & font-size scaling for Progress Bar #1814
Conversation
Bundle Size Diff
|
Plugin build for f80bc45 is ready 🛎️!
|
E2E SummaryTyping
Values above 60ms"0 - 72.13, 1 - 76.47, 2 - 65.03, 3 - 67.22, 4 - 73.50, 5 - 72.13, 6 - 75.35, 7 - 81.18, 8 - 74.27, 9 - 91.14, 10 - 71.26, 11 - 74.68, 12 - 72.35, 13 - 78.50, 14 - 72.52, 15 - 71.44, 16 - 87.14, 17 - 77.60, 18 - 79.73" |
@mghenciu, are the new values ok for Progress Bar dimensions? |
Did some testing, and the Height of the Progress bar on Mobile is consistent with the one from Desktop. So the the issue I reported is fixed ✅ I am not 100% sure I understand the values, or what was the solution. But essentially the idea was to have the same height on All Devices - since there's no device based control, and on live the height will be bigger on Mobile compared to desktop. Thank you. |
@Soare-Robert-Daniel everything's working well 👍 |
🎉 This PR is included in version 2.3.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #1776
Summary
The Progress Bar can be tiny but not too big on Mobile.
For Mobile (viewport with less than 600px width), the
height
will be between0px and 64px
instead of the fixed30px
.Screenshots
Desktop
Mobile
Test instructions
ℹ️ Progress Bar does not have responsive options; thus, the constrain is implemented.
Checklist before the final review