Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rock] Add more E2E tests #1775

Merged
merged 7 commits into from
Aug 1, 2023
Merged

[Rock] Add more E2E tests #1775

merged 7 commits into from
Aug 1, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jul 18, 2023

Closes #.

Summary

Added E2E:

  • Section
  • Tabs
  • Accordion
  • Slider
  • File loading for File e2e

Test instructions

This is dev only. The code source was not touched, so nothing should happen with the build. Just see if it can be installed without error and a light check (like inserting a block in a new post).


Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jul 18, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review July 27, 2023 11:29
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jul 27, 2023
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 192.38 KB 192.38 KB 0 B (0.00%)
Blocks 1.34 MB 1.34 MB 0 B (0.00%)
CSS 6.9 KB 6.9 KB 0 B (0.00%)
Dashboard 44.4 KB 44.4 KB 0 B (0.00%)
Export Import 4.7 KB 4.7 KB 0 B (0.00%)
Pro 225.44 KB 225.44 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 27, 2023

Plugin build for 620220b is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 27, 2023

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 53.15 3.81 52.4 89.47 (60ms) 100 (80ms)
Values above 60ms "6 - 60.18, 9 - 60.84"

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it will be possible in case of Countdown/Accordion/Slider & Tabs to also confirm the behavior in the frontend to see they work correctly?

@Soare-Robert-Daniel
Copy link
Contributor Author

@HardeepAsrani, if you mean about checking if it is the same content then we can do it.

@HardeepAsrani
Copy link
Member

@Soare-Robert-Daniel Yes, that plus to confirm clicking open the tabs and accordion, etc work as expected.

@HardeepAsrani HardeepAsrani merged commit 2b3e581 into development Aug 1, 2023
@HardeepAsrani HardeepAsrani deleted the dev/e2e-tests branch August 1, 2023 07:18
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants