-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rock] Add more E2E tests #1775
Conversation
Bundle Size Diff
|
Plugin build for 620220b is ready 🛎️!
|
E2E SummaryTyping
Values above 60ms"6 - 60.18, 9 - 60.84" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it will be possible in case of Countdown/Accordion/Slider & Tabs to also confirm the behavior in the frontend to see they work correctly?
@HardeepAsrani, if you mean about checking if it is the same content then we can do it. |
@Soare-Robert-Daniel Yes, that plus to confirm clicking open the tabs and accordion, etc work as expected. |
🎉 This PR is included in version 2.3.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #.
Summary
Added E2E:
Test instructions
This is dev only. The code source was not touched, so nothing should happen with the build. Just see if it can be installed without error and a light check (like inserting a block in a new post).
Checklist before the final review