Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image box shadow #1768

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Fix image box shadow #1768

merged 1 commit into from
Jul 14, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jul 13, 2023

Closes #1720 .

Summary

Fix the Box Shadow image extension in Editor for Core Image.

Screenshots

image


Test instructions

  1. Create a core Image Block
  2. In Inspector, activate the shadow in Box Shadow tab.
  3. You should see the shadow in Editor.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jul 13, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jul 13, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review July 13, 2023 14:56
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 192.38 KB 192.38 KB 0 B (0.00%)
Blocks 1.34 MB 1.34 MB 12 B (0.00%)
CSS 6.9 KB 6.9 KB 0 B (0.00%)
Dashboard 44.32 KB 44.32 KB 0 B (0.00%)
Export Import 4.7 KB 4.7 KB 0 B (0.00%)
Pro 225.44 KB 225.44 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for b80f417 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 56.83 10.03 55.32 84.21 (60ms) 94.74 (80ms)
Values above 60ms "6 - 61.53, 9 - 63.10, 10 - 96.02"

@rodica-andronache
Copy link

@Soare-Robert-Daniel everything's working well 👍

@HardeepAsrani HardeepAsrani merged commit 89fda3f into development Jul 14, 2023
@HardeepAsrani HardeepAsrani deleted the fix/image-shadow branch July 14, 2023 19:17
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added released Indicate that an issue has been resolved and released in a particular version of the product. pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants