-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hidden form field #1728
Add hidden form field #1728
Conversation
E2E SummaryTyping
Values above 60ms"0 - 65.23, 1 - 62.11, 4 - 69.35, 7 - 60.59, 9 - 79.63, 10 - 60.49, 12 - 76.11, 13 - 68.41" |
Bundle Size Diff
|
Plugin build for 5517b71 is ready 🛎️!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor change and it should be good to go for QA.
|
I could not reproduce the fatal error. |
@Soare-Robert-Daniel I've tried again, and the fatal error is still happening for me. Maybe this video could help to see the exact steps I take ( the fatal error occurs after activating the license ) https://www.loom.com/share/62a6e77daaee48f09755eac2f562b008?sid=7619d799-4994-4b09-ba58-fc0541fc90e1 |
@Soare-Robert-Daniel I think it's because of the wrong name of the file: https://github.com/Codeinwp/otter-blocks/blob/feat/form-hidden-field/plugins/otter-pro/inc/render/class-form-hidden-block.pnp.php It's |
@HardeepAsrani thanks for info 🙏 . It seams that local tools did not find anything strange with that odd name. Testing instance
|
@Soare-Robert-Daniel the error is gone now 🚀 but the hidden field value is not saved in the Submissions and does not appear in the Email, for me. |
@Soare-Robert-Daniel everything's working well 🚀 |
🎉 This PR is included in version 2.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #.
Summary
Add a field that is hidden from the client. Its function is to collect data from URLs to save metadata along with the submission.
URL example:
http://localhost:10007/496/form-hidden-field/?test=123
Screenshots
Editor
Inspector
Frontend
Submission
Test instructions
Checklist before the final review